apply rector level set list rules to bring codebase to php 7.4 #6550
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DAcodedBEAT
requested review from
crossan007,
DawoudIO,
MrClever,
brianteeman and
lbridgman
as code owners
10 tasks
DawoudIO
reviewed
Oct 25, 2023
src/Reports/TaxReport.php
Outdated
| @@ -340,7 +340,7 @@ public function FinishPage($curY, $fam_ID, $fam_Name, $fam_Address1, $fam_Addres | |||
| } | |||
| } | |||
| $pdf->SetFont('Times', '', 10); | |||
| $pdf->FinishPage($curY, $prev_fam_ID, $prev_fam_Name, $prev_fam_Address1, $prev_fam_Address2, $prev_fam_City, $prev_fam_State, $prev_fam_Zip, $prev_fam_Country); | |||
| $pdf->FinishPage($curY); | |||
There was a problem hiding this comment.
These changes were all applied by rector. It looks like it erroneously changed this. I'm struggling to write a reproducer for https://getrector.com/demo so we can file a ticket to their project but in the meantime, I can revert these 2 lines.
EDIT: it looks like you already updated this. Thanks! We can hold off on adding a dry-run of rector to the CI until this is resolved.
DawoudIO
reviewed
Oct 25, 2023
DawoudIO
approved these changes
Oct 26, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's this PR do?
Update language constructs to php 7.4 via rector
Screenshots (if appropriate)
N/A
What Issues does it Close?
N/A
What are the relevant tickets?
N/A
Any background context you want to provide?
As stated earlier, trying to clean up the codebase by updating to newer language constructs.
Where should the reviewer start?
Reviewing by commit is probably the best way to do this, as the changes in a commit will have similar fixes.
How should this be manually tested?
This probably shouldn't be manually tested.
How should the automated tests treat this?
This can be tested as a regular regression test.
Questions:
Is there a related website / article to substantiate / explain this change?
Does the development wiki need an update?
Does the user documentation wiki need an update?
Does this add new dependencies?
Does this need to add new data to the demo database