Fix ChangePassword Function #5148
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
crossan007
changed the title
…on into User model
These templates are shared between user and admin password changes
MrClever
approved these changes
Feb 14, 2020
|
There are still a few fringe cases I need to address here:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's this PR do?
Refactors the password change workflows to use the new
/v2API MVC paradigm.Business logic for password validation is separated from view code.
Typed exceptions are introduced for errors that crop up during a password change.
Administrative "password sets" are a different view template than a self-service user password change. If an administrator tries to "set" their own password, they'll be redirected into the user self-service password change workflow
Review the new
.featurebrowser automation tests for more detailsWhat Issues does it Close?
Closes #5145
Where should the reviewer start?
Review the new
.featurebrowser automation tests for more detailsHow should this be manually tested?
Review the new
.featurebrowser automation tests for more detailsHow should the automated tests treat this?
Review the new
.featurebrowser automation tests for more details