Ensure line endings on vendor code are lf #4697
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
assigned 
|
There's a sanity-check for committed code via StyleCI. The task added in that PR does a javascript-ified version of dos2unix on everything that's dynamically added from external (npm or composeR) |
MrClever
approved these changes
Jan 22, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's this PR do?
updates line endings on all vendor code so to use
lfinstead of mixedcrlf. This prevents integrity check errors when users (or their FTP client) runs auto-crlf on the application as it's being uploadedWhat Issues does it Close?
Closes #4684
Where should the reviewer start?
Review the output of
npm install,npm composer-install, andnpm composer-updateto ensure that the files supplied by vendors withcrlfline endings are listed by the output of thegrunt lineendingstask with a status ofconverted