-
Notifications
You must be signed in to change notification settings - Fork 461
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Keep counter Totals first for Event Types #2771
Comments
apmuth you can click the edit button on /~https://github.com/ChurchCRM/CRM/blob/master/src/EventNames.php#L52 and make the changes and submit a PR. |
This issue is stale because it has been open 30 days with no activity. Remove stale label or comment or this will be closed in 5 days. |
The line is now /~https://github.com/ChurchCRM/CRM/blob/master/src/EventNames.php#L49 and the change still holds to be inculcated. |
Can you create a quick PR and I'll merge it |
Line 48 causes an explode to populate the array. --- /blob/master/src/EventNames.php Mon Jun 3 12:47:50 2024
+++ /blob/master/src/EventNames.php Mon Jun 3 12:49:11 2024
@@ -46,7 +46,7 @@
$eRecur = $_POST['newEvtTypeRecur'];
$eCntLst = $_POST['newEvtTypeCntLst'];
$eCntArray = array_filter(array_map('trim', explode(',', $eCntLst)));
- $eCntArray[] = 'Total';
+ array_unshift($eCntArray, 'Total');
$eCntNum = count($eCntArray);
$theID = $_POST['theID'];
|
# Description & Issue number it closes <!-- Please include a summary of the changes and the related issue. Please also include relevant motivation and context. --> Resolves #2771 ## Screenshots (if appropriate) <!-- Before and after --> None. ## How to test the changes? Visual inspection. ## Type of change - [x] Bug fix (non-breaking change which fixes an issue) - [ ] New feature (non-breaking change which adds functionality) - [ ] Breaking change (fix or feature that would cause existing functionality to not work as expected) - [ ] This change requires a documentation update # How Has This Been Tested? <!-- Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration --> Visual inspection. # Checklist: - [x] My code follows the style guidelines of this project - [x] I have performed a self-review of my code - [ ] I have commented my code, particularly in hard-to-understand areas - [ ] I have made corresponding changes to the documentation - [x] My changes generate no new warnings - [ ] I have added tests that prove my fix is effective or that my feature works - [ ] New and existing unit tests pass locally with my changes - [ ] Any dependent changes have been merged and published in downstream modules
Replace Line 52 of
EventNames.php
:with
The text was updated successfully, but these errors were encountered: