Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add simulator to installers #18964

Merged
merged 2 commits into from
Dec 3, 2024
Merged

Add simulator to installers #18964

merged 2 commits into from
Dec 3, 2024

Conversation

cmmarslender
Copy link
Contributor

@cmmarslender cmmarslender commented Dec 2, 2024

Purpose:

Enables using the simulator from the installers

Current Behavior:

start_simulator is missing from the installers, so chia start simulator fails with an error in the error logs

New Behavior:

start_simulator is included in the installers, so chia start simulator works

Testing Notes:

@cmmarslender cmmarslender added the Added Required label for PR that categorizes merge commit message as "Added" for changelog label Dec 2, 2024
@cmmarslender cmmarslender changed the title Add start simulator to installers Add simulator to installers Dec 2, 2024
@cmmarslender cmmarslender marked this pull request as ready for review December 2, 2024 22:17
@cmmarslender cmmarslender requested a review from a team as a code owner December 2, 2024 22:17
Copy link

Pull Request Test Coverage Report for Build 12128286462

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 27 unchanged lines in 7 files lost coverage.
  • Overall coverage increased (+0.02%) to 91.206%

Files with Coverage Reduction New Missed Lines %
chia/daemon/keychain_proxy.py 1 73.16%
chia/farmer/farmer.py 1 72.52%
chia/server/node_discovery.py 2 79.82%
chia/daemon/client.py 2 74.01%
chia/wallet/wallet_node.py 4 88.03%
chia/full_node/full_node.py 6 86.17%
chia/timelord/timelord.py 11 78.8%
Totals Coverage Status
Change from base Build 12125539501: 0.02%
Covered Lines: 103595
Relevant Lines: 113389

💛 - Coveralls

Copy link
Contributor

@wjblanke wjblanke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

aok

@cmmarslender cmmarslender merged commit ac45a37 into main Dec 3, 2024
362 checks passed
@cmmarslender cmmarslender deleted the sim-to-installers branch December 3, 2024 04:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Added Required label for PR that categorizes merge commit message as "Added" for changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants