Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CHIA-1787] Add ergonomic message condition drivers #18931

Merged
merged 2 commits into from
Dec 4, 2024

Conversation

Quexington
Copy link
Contributor

Right now, there's no easy way to work with message conditions when you're constructing spends. This PR expands on the current drivers to make it much easier to work with.

Worth noting this is technically a breaking change to the extra_conditions argument in the RPCs because I changed the naming of some of the fields, but I think it's worth it and would highly doubt that anyone will be affected.

Copy link

coveralls-official bot commented Nov 25, 2024

Pull Request Test Coverage Report for Build 12033845764

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 181 of 181 (100.0%) changed or added relevant lines in 2 files are covered.
  • 29 unchanged lines in 8 files lost coverage.
  • Overall coverage decreased (-0.003%) to 91.188%

Files with Coverage Reduction New Missed Lines %
chia/wallet/util/wallet_sync_utils.py 1 86.07%
chia/server/server.py 1 81.9%
chia/util/files.py 2 91.38%
chia/rpc/rpc_server.py 3 88.2%
chia/wallet/wallet_node.py 3 88.04%
chia/timelord/timelord_launcher.py 4 89.29%
chia/server/node_discovery.py 7 79.45%
chia/full_node/full_node.py 8 86.14%
Totals Coverage Status
Change from base Build 12016365364: -0.003%
Covered Lines: 103632
Relevant Lines: 113451

💛 - Coveralls

@Quexington Quexington marked this pull request as ready for review November 26, 2024 15:28
@Quexington Quexington requested a review from a team as a code owner November 26, 2024 15:28
@Quexington Quexington added Added Required label for PR that categorizes merge commit message as "Added" for changelog and removed coverage-diff labels Nov 26, 2024
@Quexington Quexington changed the title Add ergonomic message condition drivers [CHIA-1787] Add ergonomic message condition drivers Nov 26, 2024
@Quexington Quexington added the ready_to_merge Submitter and reviewers think this is ready label Dec 4, 2024
@pmaslana pmaslana merged commit 197ea79 into main Dec 4, 2024
364 of 365 checks passed
@pmaslana pmaslana deleted the quex.message_condition_ergonomics branch December 4, 2024 18:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Added Required label for PR that categorizes merge commit message as "Added" for changelog ready_to_merge Submitter and reviewers think this is ready
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants