-
-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
App crashes if scroll through large chat #977
Comments
Some additional info. If you slowly scrolled through a chat and all media (pics) are loaded, the app doesn’t crash anymore. |
Thanks for the report! I'm pretty sure that crash was introduced a long time ago and just hasn't been properly fixed yet. Narrowing it down to the picture loading process is helpful |
This issue has been very difficult to solve and was introduced around the time I merged a PR that auto-loads your history as your scroll up. I think we may end up completely redoing the messaging UI and rewriting it from scratch. |
Hi, I just want to add, that its a problem with the newest version too. Also scrolling slowly does not help, its always crashing. |
Are there media messages in the chat history? As a workaround you could try swipe-to-delete to clear the chat history. |
Likely related to #998 |
Yeap, it contains some media messages. As I said before, I think media preview is involved in the crash. |
Aaaand yes, I can relate that wiping a history solves the issue but creates a new one: there is no way to keep a large chat history with media messages. Chris, I hope you will figure it out because it’s quite a big problem for user experience. |
It will be solved eventually, having to delete message history to fix a crash bug is pretty awful. |
Seeing this too on iOS11.3 and 4.3.0, OMEMO group, plenty of media |
I could be wrong, but I think the answer given by @stigger in #817 related to commenting out a few lines in JSQMessagesCollectionViewFlowLayout fixes this issue and the related ones like #1038. It seems to fix it for us. It doesn't appear this has been updated in the ChatSecure fork of JSQMessagesViewController. |
Resolved in v4.3.6 |
The latest beta crashes if you scroll fast enough through big chat. I had sent few crash logs. This crash is pretty reproducible.
The text was updated successfully, but these errors were encountered: