Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

App crashes if scroll through large chat #977

Closed
cringeops opened this issue Mar 21, 2018 · 13 comments
Closed

App crashes if scroll through large chat #977

cringeops opened this issue Mar 21, 2018 · 13 comments

Comments

@cringeops
Copy link

The latest beta crashes if you scroll fast enough through big chat. I had sent few crash logs. This crash is pretty reproducible.

@cringeops
Copy link
Author

Some additional info. If you slowly scrolled through a chat and all media (pics) are loaded, the app doesn’t crash anymore.
Guess it has something to do with pics loading process.

@chrisballinger
Copy link
Member

Thanks for the report! I'm pretty sure that crash was introduced a long time ago and just hasn't been properly fixed yet. Narrowing it down to the picture loading process is helpful

@cringeops
Copy link
Author

Image
Chat view corruption after fast scrolling. Some message bubbles are heavily scrambled and other artifacts are observable.

@chrisballinger
Copy link
Member

This issue has been very difficult to solve and was introduced around the time I merged a PR that auto-loads your history as your scroll up. I think we may end up completely redoing the messaging UI and rewriting it from scratch.

@Loader23
Copy link

Hi,

I just want to add, that its a problem with the newest version too. Also scrolling slowly does not help, its always crashing.

@chrisballinger
Copy link
Member

Are there media messages in the chat history? As a workaround you could try swipe-to-delete to clear the chat history.

@chrisballinger
Copy link
Member

Likely related to #998

@cringeops
Copy link
Author

Yeap, it contains some media messages. As I said before, I think media preview is involved in the crash.

@cringeops
Copy link
Author

Aaaand yes, I can relate that wiping a history solves the issue but creates a new one: there is no way to keep a large chat history with media messages. Chris, I hope you will figure it out because it’s quite a big problem for user experience.

@chrisballinger
Copy link
Member

It will be solved eventually, having to delete message history to fix a crash bug is pretty awful.

@licaon-kter
Copy link
Contributor

Seeing this too on iOS11.3 and 4.3.0, OMEMO group, plenty of media

@GlacierSecurityInc
Copy link

I could be wrong, but I think the answer given by @stigger in #817 related to commenting out a few lines in JSQMessagesCollectionViewFlowLayout fixes this issue and the related ones like #1038. It seems to fix it for us.

It doesn't appear this has been updated in the ChatSecure fork of JSQMessagesViewController.

chrisballinger added a commit that referenced this issue Dec 7, 2018
@chrisballinger
Copy link
Member

Resolved in v4.3.6

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants