Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Chartboost Mediation Unity SDK 4.7.0 into Develop #211

Merged
merged 7 commits into from
Nov 14, 2023
Merged

Chartboost Mediation Unity SDK 4.7.0 into Develop #211

merged 7 commits into from
Nov 14, 2023

Conversation

SCastanedaMunoz
Copy link
Collaborator

Title

Chartboost Mediation Unity SDK 4.7.0 into Main

Description

Chartboost Mediation Unity SDK 4.7.0 into Main

Type of change

  • Bug fix (fixes an issue)
  • New feature (adds functionality)
  • Refactor / Maintenance (refactoring code to be cleaner/easier to maintain)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Checklist:

  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

SCastanedaMunoz and others added 7 commits November 8, 2023 14:13
@SCastanedaMunoz
[HB-6747] Passing Context when Getting Partner Consent (#206)
47781fa
@SCastanedaMunoz
[HB-6715] 4.7.0 CHANGELOG.md & Documentation (#207)
583fb75
@kushG
[HB-6524] Public NuGet Distribution (#205)
45194b6
@kushG @helium-service
[HB-6714] Compare SDK Version Against Versions inpackage.json and `…
d919176 
….nuspec` (#208)

* version compare tests added

* Updating Chartboost.CSharp.Mediation.Unity.nupkg

---------

Co-authored-by: helium-service <helium-service@chartboost.com>
@kushG
[HB-6524] Update status.yml (#209)
8b51071 
* Update status.yml

Signed-off-by: kushG <kushagrag@sturfee.com>
@kushG
[HB-6714] VersionCompareTest Fix for NuGet (#210)
a4c4675
@kushG
Update README.md
bdeffa3 
Signed-off-by: kushG <kushagrag@sturfee.com>
@SCastanedaMunoz SCastanedaMunoz added the release SDK release label Nov 14, 2023
@SCastanedaMunoz SCastanedaMunoz added this to the 4.7.0 milestone Nov 14, 2023
@SCastanedaMunoz SCastanedaMunoz requested review from kushG and a team November 14, 2023 21:08
@SCastanedaMunoz SCastanedaMunoz requested review from bwised and cb-jpadilla and removed request for a team November 14, 2023 21:08
cb-jpadilla
cb-jpadilla approved these changes Nov 14, 2023
View reviewed changes
Copy link
Contributor

@cb-jpadilla cb-jpadilla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm

@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 14, 2023 •
edited
Loading

Test Results

5 tests  +4   5 ✔️ +4   0s ⏱️ ±0s
1 suites ±0   0 💤 ±0 
1 files   ±0   0 ❌ ±0 

Results for commit bdeffa3. ± Comparison against base commit 8ac0b59.

This pull request removes 1 and adds 5 tests. Note that renamed tests count towards both. 
ExhaustiveJsonTest

AddPartnerConsent
ClearConsent
RemovePartnerConsent
ResetConsent
SetPartnerConsent

♻️ This comment has been updated with latest results.

@SCastanedaMunoz SCastanedaMunoz merged commit c3548ea into develop Nov 14, 2023
@SCastanedaMunoz SCastanedaMunoz changed the title Chartboost Mediation Unity SDK 4.7.0 into Main Chartboost Mediation Unity SDK 4.7.0 into Develop Nov 14, 2023
@kushG kushG mentioned this pull request Nov 14, 2023
Closed
12 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kushG kushG kushG approved these changes

@cb-jpadilla cb-jpadilla cb-jpadilla approved these changes

@bwised bwised Awaiting requested review from bwised bwised was automatically assigned from ChartBoost/helium-unity

Assignees

@kushG kushG

@SCastanedaMunoz SCastanedaMunoz

Labels
release SDK release
Projects
None yet
Milestone
4.7.0
Development

Successfully merging this pull request may close these issues.
3 participants
@SCastanedaMunoz @kushG @cb-jpadilla