-
-
Notifications
You must be signed in to change notification settings - Fork 30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ensure stable ordering within same slot #67
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
7770590
to
37a079c
Compare
Serialization now needs to be adjusted as it currently ignores the transaction index.
This has a side-benefits of making the database a bit more compact although the marking / removing of inputs may now be slightly less efficient (haven't run benchmarks yet; soon). The new index isn't used yet.
1a25c8f
to
85df95d
Compare
Going for 'most_recent_first' and 'oldest_first' instead of 'asc' or 'desc' for more clarity. We could do something slightly more elaborate if there was multiple criteria to sort on, but only the sorting direction is configurable here.
85df95d
to
81d41e5
Compare
…ers. Instead of building a pyramid of pattern matches, we can flatten it all using a do-syntax and an appropriate monad.
… to the test bench.
ceb27fc
to
5f16a32
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #65
📍 Refactor: extract serialization / deserialization logic for output reference.
📍 Include transaction index within block when folding on blocks.
Serialization now needs to be adjusted as it currently ignores the transaction index.
📍 Rework OutputReference serialization to include transaction index.
This has a side-benefits of making the database a bit more compact although the marking / removing of inputs may now be slightly less efficient (haven't run benchmarks yet; soon).
The new index isn't used yet.
📍 Order by descending created_at slot & fallback to transaction index when equal.
📍 Add specification & supporting code for changing results order
Going for 'most_recent_first' and 'oldest_first' instead of 'asc' or
'desc' for more clarity.
We could do something slightly more elaborate if there was multiple
criteria to sort on, but only the sorting direction is configurable
here.
📍 re-introduce policy-id and asset-name in API doc, as deprecated parameters.
📍 Create Makefile to group common commands and build instructions.
📍 Refactor: leverage 'Either a' monad to simplify writing of Http handlers.
Instead of building a pyramid of pattern matches, we can flatten it all using a do-syntax and an appropriate monad.
📍 Wire new 'order' query parameter through the API.
📍 Fix dynamic pattern addition end-to-end scenario & add more debugging to the test bench.