Separate ROMSComponent.input_datasets into more specific attributes
#112
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 5 commits
September 26, 2024 16:00
…nsibilities previously held by Case
- Simplify Case.persist to call to_dict on each component #TODO: - Define Component.to_dict for common attributes and: - call super() in ROMSComponent.to_dict - delete MARBLComponent.to_dict (defer to base class)
- Make input_datasets a _property_ on ROMSComponent that lists any instances of _new ROMSComponent attributes_: - model_grid (ROMSModelGrid, optional) - initial_conditions (ROMSInitialConditions, optional) - tidal_forcing (ROMSTidalForcing, optional) - surface_forcing (list[ROMSSurfaceForcing], optional) - boundary_forcing (list[ROMSBoundaryForcing], optional) - Add 'to_dict' method on InputDataset class (returns dict of kwargs that can be used to initialize the class instance) - Simplify ROMSComponent.to_dict and ROMSComponent.from_dict - Reformat example blueprints according to above changes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Branches off #109 , merge #109 and then update the diff here before review.
Closes #94.
Have chosen to keep
ROMSComponent.input_datasetsas a property that collects them all in a list.