[CBRD-25285] Add a new ClassLoader to avoid reloading classes that load JNI in a Java SP Server #5076
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
beyondykk9
approved these changes
Apr 5, 2024
ctshim
reviewed
Apr 5, 2024
src/executables/loadjava.cpp
Outdated
| {0, 0, 0, 0} | ||
| }; | ||
|
|
||
| while (1) | ||
| { | ||
| int option_index = 0; | ||
| int option_key = getopt_long (argc, argv, "yh", loadjava_option, &option_index); | ||
| int option_key = getopt_long (argc, argv, "y:jh", loadjava_option, &option_index); |
There was a problem hiding this comment.
Why did you add ':'?
Using ':' means there are arguments.
Does the '-y' option have additional arguments?
ctshim
approved these changes
Apr 5, 2024
hyunikn
reviewed
Apr 5, 2024
| @@ -914,7 +914,8 @@ $set 34 MSGCAT_UTIL_SET_LOADJAVA | |||
| Usage: loadjava [OPTION] database-name java-class-file\n\ | |||
| \n\ | |||
| valid options:\n\ | |||
| -y, --overwrite Klassendatei, wenn vorhanden, überschreiben, Standard nein\n | |||
| -y, --overwrite Klassendatei, wenn vorhanden, überschreiben, Standard nein\n\ | |||
| -j, --jni add a Class or Jar to static loading for JNI\n | |||
hyunikn
approved these changes
Apr 5, 2024
|
build-windows fails casued by compiling It seems not related to this PR, I'm going to merge the PR. |
hgryoo
added a commit
to hgryoo/cubrid
that referenced
this pull request
Apr 5, 2024
…ad JNI in a Java SP Server (CUBRID#5076) http://jira.cubrid.org/browse/CBRD-25285 A new classloader (StoredProcedureStaticClassLoader) will be added to avoid reloading classes that load JNI. By loadjava's -j option, classes are copied to /java_static directory and the classloader will try to find classes in the path. The classloader does not check whether any file is modified in the path, Also is not be re-initialized like StoredProcedureClassLoader. To update overwritten classes in /java_static, restarting Java SP server(cub_javasp) is required.
mhoh3963
pushed a commit
that referenced
this pull request
Apr 5, 2024
…ad JNI in a Java SP Server (#5076) (#5090) http://jira.cubrid.org/browse/CBRD-25285 A new classloader (StoredProcedureStaticClassLoader) will be added to avoid reloading classes that load JNI. By loadjava's -j option, classes are copied to /java_static directory and the classloader will try to find classes in the path. The classloader does not check whether any file is modified in the path, Also is not be re-initialized like StoredProcedureClassLoader. To update overwritten classes in /java_static, restarting Java SP server(cub_javasp) is required.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
http://jira.cubrid.org/browse/CBRD-25285
A new classloader (
StoredProcedureStaticClassLoader) will be added to avoid reloading classes that load JNI. Byloadjava's-joption, classes are copied to/java_staticdirectory and the classloader will try to find classes in the path.The classloader does not check whether any file is modified in the path, Also is not be re-initialized like
StoredProcedureClassLoader. To update overwritten classes in/java_static, restarting Java SP server(cub_javasp) is required.