Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[CBRD-24949] CAS Protocol V12, send oracle_compat_number_behavior system parameter to the clients #4620

Merged
merged 3 commits into from
Aug 30, 2023
Merged

[CBRD-24949] CAS Protocol V12, send oracle_compat_number_behavior system parameter to the clients #4620

merged 3 commits into from
Aug 30, 2023

Conversation

airnet73
Copy link
Contributor

http://jira.cubrid.org/browse/CBRD-24949

Purpose

  • to eliminate user confusion, 2-way expression is unified with the oracle_compat_number_behavior system parameter.
  • in order for the broker to deliver the value of the system parameters including oracle_compat_number_behavior to the client, the broker extends the broker info that the client receives using the RESERVED field.
  • Change the CAS Protocol version from PROTOCOL_V11 to PROTOCOL_V12 to express the extension of the above protocol

Implementation
N/A

Remarks
N/A

@airnet73
[CBRD-24949]
0dbe03a 
CAS Protocol V12, send oracle_compat_number_behavior system parameter to the clients
@airnet73 airnet73 requested a review from kisoo-han August 29, 2023 10:02
@airnet73 airnet73 self-assigned this Aug 29, 2023
kisoo-han
kisoo-han approved these changes Aug 29, 2023
View reviewed changes
Copy link
Contributor

@kisoo-han kisoo-han left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

check code-style CI fails & build failure for BROKER_INFO_RESERVED2 -> BROKER_INFO_SYSTEM_PARAM
cas_meta.c
cas_protocol.h

@airnet73
Copy link
Contributor Author

@kisoo-han
Added V12 protocol in shard.

@airnet73 airnet73 requested a review from kisoo-han August 30, 2023 03:38
@airnet73 airnet73 merged commit 0c0f787 into CUBRID:develop Aug 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kisoo-han kisoo-han kisoo-han approved these changes

Assignees

@airnet73 airnet73

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@airnet73 @kisoo-han