-
Notifications
You must be signed in to change notification settings - Fork 126
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[CBRD-24564] reflect reuse-oid option in error message prining at view updating query. #3959
Conversation
…w updating query.
Is there any case where the MSGCAT_RUNTIME_VCLASS_NOT_UPDATABE error occurs and is unrelated to the reuse_oid table? |
In addition to msg/en_US/cubrid.msg, other message files must also be changed. And even if there is more than one reuse_oid table, only one table name is printed in the error message.
I think the purpose of this change is to make the meaning clear to users. In addition, the code becomes complicated by continuously passing unnecessary arguments only for error message output. The reason why users cannot clearly understand the error message is that they do not understand reuse_oid.
|
The message is made from discussion enough of the issue. The reuse_oid table related to the view is minimal information for showing the reason of the fail. And the error messages will be added as multilingual version. |
The unauthorized table which is not granted (SELECT ONLY) from the user is not updatable. |
If the same error code is specified for multiple cases, IMO, the same detailed level of error message should be displayed. |
http://jira.cubrid.org/browse/CBRD-24564
The updating query with a view can be faced with error when the included table in the view has reuse-oid option. However, the error message does not reflect the option as the below message.
AS-IS:
TO-BE:
ERROR: Vclass dba.v3 is not updatable, because dba.t1 is reuse_oid table.