[LASlib] Prevent usage of LASlib with msvc 2017 #8474
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sloriot
reviewed
Sep 9, 2024
| @@ -103,6 +107,7 @@ else() | |||
| target_link_libraries(ply_plugin PUBLIC scene_points_with_normal_item scene_polygon_soup_item scene_surface_mesh_item scene_textured_item) | |||
| target_compile_features(ply_plugin PRIVATE ${needed_cxx_features}) | |||
|
|
|||
| #disable if MSVC 2017 | |||
There was a problem hiding this comment.
Suggested change
| #disable if MSVC 2017 |
| @@ -37,6 +41,7 @@ foreach(cppfile ${cppfiles}) | |||
| endif() | |||
| else() | |||
| if("${cppfile}" STREQUAL "test_LAS.cpp") | |||
| #disable if MSVC 2017 | |||
There was a problem hiding this comment.
Suggested change
| #disable if MSVC 2017 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of Changes
LASlib is not compatible with msvc 2017
Release Management