-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
TestSuite: List of third-party libraries #8254
Merged
lrineau
merged 31 commits into
CGAL:master
from
SaillantNicolas:List-third-party-libraries-GF
Sep 25, 2024
Merged
TestSuite: List of third-party libraries #8254
lrineau
merged 31 commits into
CGAL:master
from
SaillantNicolas:List-third-party-libraries-GF
Sep 25, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Because FindVTK redefines `lib` to something else!
lrineau
approved these changes
Aug 23, 2024
I had a look at the code. It seems fine. You seems almost through, now. Just OpenMesh and ITT? |
@SaillantNicolas I have pushed this commit directly.
Yes and also OSQP. |
``` Source file /home/lrineau/CGAL/collect_and_public_testresults/TESTRESULTS/../Summary_Script.js does not exist. at ./create_testresult_page line 898. ``` .. and another fix about `/usr/sbin/restorecon`.
``` Source file /home/lrineau/CGAL/collect_and_public_testresults/TESTRESULTS/../Summary_Script.js does not exist. at ./create_testresult_page line 898. ```
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of Changes
This PR adds a table in the Summary page which lists third-party libraries for all platforms. This table can be sorted by clicking on the top cells. In this table you can also click on a third-party library to display a modal which lists all the versions and platforms of this library (This modal is also sortable).
A change also in the creation of this Summary page, the Javascript part is now in a separate .js file. The generation of JSON has also been revised.
For a preview of what this task will look like, click here.
This PR needs this one CGAL/cgal-testsuite-docker#159
Libraries and Their Status:
Release Management