Mesh_3 - avoid a timeout in the testsuite #7825
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sloriot
added
Batch_1
|
7 timeouts in 6.0-I-90 and 4 in CGAL-6.0-Ic-93 |
|
Successfully tested in CGAL-6.0-Ic-96 (no time out!) |
lrineau
added
the
rm only: ready for master
lrineau
removed
the
rm only: ready for master
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of Changes
Tests of Mesh_3 in the daily testsuite (too) often end with timeouts, because of the test
test_meshing_without_features_determinism. This happens on many different platforms.This PR reduces the target dihedral angle from 10 degrees to 9 degrees for
CGAL::perturb_mesh_3()to fit in the testsuite timeout.My experiments showed that the perturber always succeeds to get to 10 degrees, but it may be long and go beyond the timeout, in particular in Debug mode. This test is not about the perturber itself, but about determinism, so it must not be considered as a regression.
Release Management