Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correcting stylesheet name #7766

Merged
merged 1 commit into from
Oct 19, 2023

Conversation

albert-github
Copy link
Contributor

The name stylesheet.css is replaced by a better name cgal_stylesheet.css a while ago, but apparently these 2 files were not updated.

The name `stylesheet.css` is replaced by a better name `cgal_stylesheet.css` a while ago, but apparently these 2 files were not updated.
@lrineau
Copy link
Member

lrineau commented Oct 9, 2023

I am surprised that https://doc.cgal.org/latest/Manual/how_to_cite_cgal.html does use cgal_stylesheet.css. Do you know why?

@albert-github
Copy link
Contributor Author

albert-github commented Oct 10, 2023

As far as I can quickly see there is only one place where the stylsheet is used i.e. <h1>, but I could imagine that is would be used at other places as well (the <a>, the <pre>)

At the moment the how_to_cite.html (not the how_to_cite_cgal is the file we are talking about) is just a "stand alone" page that is called from how_to_cit_cgal.html through the bib links without the "CGAL header" and without the tree view. I think it would also be worthwhile to adjust this (but that would be something for a different enhancement issue / pull request).

At the moment though the usage of stylesheet.css is not correct and should either be removed or replaced as suggested in this proposed PR.

@sloriot sloriot added the Batch_1 First Batch of PRs under testing label Oct 11, 2023
@lrineau lrineau added this to the 6.0-beta milestone Oct 13, 2023
@sloriot sloriot added Under Testing Tested and removed Batch_1 First Batch of PRs under testing Under Testing labels Oct 15, 2023
@sloriot
Copy link
Member

sloriot commented Oct 18, 2023

Successfully tested in CGAL-6.0-Ic-86

@lrineau lrineau self-assigned this Oct 19, 2023
@lrineau lrineau added the rm only: ready for master For the release team only: that indicates that a PR is about to be merged in 'master' label Oct 19, 2023
@lrineau lrineau merged commit 1ae1d21 into CGAL:master Oct 19, 2023
@lrineau lrineau removed the rm only: ready for master For the release team only: that indicates that a PR is about to be merged in 'master' label Oct 19, 2023
@lrineau lrineau deleted the feature/bug_stylesheet_name branch October 19, 2023 13:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants