Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(java): ✨ adding web app support for mobile #483

Merged
merged 13 commits into from
Jun 13, 2023
Merged

feat(java): ✨ adding web app support for mobile #483

merged 13 commits into from
Jun 13, 2023

Conversation

WasiqB
Copy link
Member

@WasiqB WasiqB commented May 29, 2023 •
edited
Loading

Closes: #128

Type of changes?

  • Bug fixes: Non-breaking change which fixes an issue
  • New feature: Non-breaking change which adds a new feature
  • Performance improvement: Non-breaking change which improves performance
  • Documentation: Non-breaking change which improves documentation
  • Other: Non-breaking change which does not fit into the above categories
  • Breaking change: A breaking change which requires a new version of the library

Checklist for Java project

  • Change not related to Java project

Following checklists are optional if above checkbox is selected:

  • Copyright banner comment added to newly added files, except `.md`, `.yml`, `*.json`?
  • Proper JavaDoc updated in main and test classes for all public classes and methods?
  • Tests added for changes?
  • Tests are passing locally?
  • Check style checks are passing locally?
  • Test coverage is at least 80% for newly added changes?
  • There are no SonarCloud issues?
  • README updated? (if applicable)
  • Documentation website updated for the PR raised?

Checklist for Website

  • Change not related to Website project

Following is optional if above checkbox is selected:

  • Lint check passes locally?
  • Prettier check passes locally?
  • Build command working fine locally?

Reviewers

@BoykaFramework/boyka-core

IMPORTANT: Make sure to check the `Allow edits from maintainers` box below this window

@github-actions github-actions bot added the 🚀 pr: new feature PR which introduces new features label May 29, 2023
@ghost
Copy link

ghost commented May 29, 2023 •
edited by ghost
Loading

👇 Click on the image for a new way to code review

Review these changes using an interactive CodeSee Map

Legend

CodeSee Map legend

@WasiqB WasiqB linked an issue Jun 6, 2023 that may be closed by this pull request
Mobile: Support Mobile web applications #128
Closed
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

82.1% 82.1% Coverage
0.0% 0.0% Duplication

@WasiqB WasiqB marked this pull request as ready for review June 13, 2023 09:10
@WasiqB WasiqB requested a review from a team as a code owner June 13, 2023 09:10
@WasiqB WasiqB requested a review from mfaisalkhatri June 13, 2023 09:10
@WasiqB WasiqB merged commit 272836b into develop Jun 13, 2023
@WasiqB WasiqB deleted the issue-128 branch June 13, 2023 09:11
WasiqB added a commit that referenced this pull request Jun 15, 2023
@WasiqB
feat(java): ✨ adding web app support for mobile (#483)
193d611
WasiqB added a commit that referenced this pull request Jul 18, 2023
@WasiqB
feat(java): ✨ adding web app support for mobile (#483)
f4f59e8
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mfaisalkhatri mfaisalkhatri Awaiting requested review from mfaisalkhatri mfaisalkhatri was automatically assigned from BoykaFramework/boyka-core

Assignees
No one assigned
Labels
🚀 pr: new feature PR which introduces new features
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Mobile: Support Mobile web applications
1 participant
@WasiqB