Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: attempting to unmarshall some arrays twice #380

Merged
merged 1 commit into from
Feb 2, 2025
Merged

fix: attempting to unmarshall some arrays twice #380

merged 1 commit into from
Feb 2, 2025

Conversation

bdraco
Copy link
Member

@bdraco bdraco commented Feb 2, 2025

The loop would never be entered so it did not break but it would do some unneed dict lookups
Screenshot 2025-02-01 at 10 43 27 PM

The loop would never be entered so it did not break but
it would do some unneed dict lookups
@bdraco bdraco changed the title fix: attempting to unmarshall arrays twice fix: attempting to unmarshall some arrays twice Feb 2, 2025
Copy link

codecov bot commented Feb 2, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 83.96%. Comparing base (1aab230) to head (6237a47).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #380      +/-   ##
==========================================
+ Coverage   83.88%   83.96%   +0.08%     
==========================================
  Files          28       28              
  Lines        3381     3381              
  Branches      607      607              
==========================================
+ Hits         2836     2839       +3     
+ Misses        338      334       -4     
- Partials      207      208       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

codspeed-hq bot commented Feb 2, 2025

CodSpeed Performance Report

Merging #380 will not alter performance

Comparing fix_array (6237a47) with main (1aab230)

Summary

✅ 3 untouched benchmarks

@bdraco bdraco merged commit 586dc23 into main Feb 2, 2025
20 checks passed
@bdraco bdraco deleted the fix_array branch February 2, 2025 04:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant