-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
improve presup performance #94
Conversation
How much time does this save (in your machine)? I once did similar to get a better performance, but in my machine the improvement was not significant |
My machine is probably too old (10 years) to a point that it has been slower than github's action runner, but these changes turn the proof checking from very long to short enough for me to stare at the buffer to wait for it to finish (but still long). |
though it could have been faster before, checking the CI /~https://github.com/Beluga-lang/McLTT/actions It was 9m ish before this change #91 making the CI above 12m. now this PR drops it down to 11m. If you have some ideas maybe you can do something. |
It is strange... That PR added just one module and a lemma for syntax, which should not take 2 or 3 mins. I will also try some optimizations.
OK, if that's the case, let's merge this PR. |
I know. I also find it strange, but the drop is sudden and clear. if you compare this PR and the other one, you will see that there is an improvement in this PR. |
@HuStmpHrrr Actually, that added 3 min is not from library checking. It is from OCaml setup! What... C.f. /~https://github.com/Beluga-lang/McLTT/actions/runs/9343409604/job/25712951655?pr=95 of #95 It seems like it was a problem of |
It should be fixed in #96 (together with a bit of improvement in NatCases time) |
The current performance of presup kills me. This is the minimal effort I can do to improve the performance. The idea is to lower the search level to reduce useless search effort.