Fix bug where cloak doesn't generate any routes at all when CONTENTFUL_PREVIEW=true #57
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…s/contentful.coffee can use it. Trying to fix bug where no routes were generated when CONTENTFUL_PREVIEW=true.
|
That woks for me! Tagged with /~https://github.com/BKWLD/cloak/releases/tag/v1.15.4 |
|
Thank you 🙏 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I upgraded HFO to cloak
^1.15.3, and now the staging site doesn't generate any routes at all. I poked around and it looks likecloak/services/contentful.coffeeuses the wrong token when it generates routes. (See screenshot below).To solve this, I extracted the contentful token logic from
cms.coffeeand put it in a shared function so thatcontentful.coffeecan use it too. Now when I test locally, craft generates the preview routes as intended. Maybe you have a better pattern in mind for doing this, but having a fix for this would be great.