Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove zoningSetup LOD setting and instead add two more ZoningCriteri… #758

Merged
merged 7 commits into from
Dec 10, 2024
Merged

remove zoningSetup LOD setting and instead add two more ZoningCriteri… #758

merged 7 commits into from
Dec 10, 2024

Conversation

DaJansenGit
Copy link
Member

  • remove zoningSetup LOD setting
  • instead add two more ZoningCriteria Enums to be more understandable
  • add cpu_time for teaser result (is there a result for energyplus as well @veronikarichter ?)

@veronikarichter
Copy link
Member

veronikarichter commented Dec 9, 2024 •
edited
Loading

@DaJansenGit
I don't have the CPU Time as an export variable. You could measure the wall clock time though within bim2sim, if interested.

@DaJansenGit DaJansenGit merged commit 27eef88 into development Dec 10, 2024
1 check passed
@DaJansenGit DaJansenGit deleted the refactor_zoning_settings branch December 10, 2024 10:04
@DaJansenGit
Copy link
Member Author

@DaJansenGit I don't have the CPU Time as an export variable. You could measure the wall clock time though within bim2sim, if interested.

not needed currently, we can add this if we need it at some point.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@veronikarichter veronikarichter veronikarichter approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@DaJansenGit @veronikarichter