Added preferred locations to readme #39812
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andrewmathew1
changed the title
|
API change check API changes are not detected in this pull request. |
kushagraThapar
approved these changes
Feb 20, 2025
There was a problem hiding this comment.
thanks @andrewmathew1 for these changes. IMO, we should clarify the behavior for read and write requests separately. However, that can be done once @tvaron3 introduces the effective preferred locations feature.
simorenoh
requested changes
Feb 21, 2025
|
[like] Fabian Meiswinkel reacted to your message:
…________________________________
From: Simon Moreno ***@***.***>
Sent: Friday, February 21, 2025 5:01:43 PM
To: Azure/azure-sdk-for-python ***@***.***>
Cc: Fabian Meiswinkel ***@***.***>; Review requested ***@***.***>
Subject: Re: [Azure/azure-sdk-for-python] Added preferred locations to readme (PR #39812)
@simorenoh requested changes on this pull request.
LGTM for the most part, let's just please change any mentions of preferredLocations in camelcase to what it actually is (preferred_locations) in order to avoid any sort of confusion.
—
Reply to this email directly, view it on GitHub<#39812 (review)>, or unsubscribe</~https://github.com/notifications/unsubscribe-auth/AESG6VU44N7WKEVEPCAW4UT2Q5LXPAVCNFSM6AAAAABXR3WCXGVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZDMMZTG4YTEOBWGI>.
You are receiving this because your review was requested.Message ID: ***@***.***>
|
simorenoh
approved these changes
Feb 25, 2025
andrewmathew1
deleted the
users/andrewmathew1/addingpreferredlocationsdocs
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Added preferred location section to readme