Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use SharedExecutorService in more locations #42468

Merged
merged 5 commits into from
Oct 23, 2024
Merged

Use SharedExecutorService in more locations #42468

merged 5 commits into from
Oct 23, 2024

Conversation

alzimmermsft
Copy link
Member

Description

Replaces usage of one-off ExuecutorServices with SharedExecutorService, as most usages of ExecutorService should route through SharedExecutorService as it allows customers more control over the Azure SDK for Java threading story.

All SDK Contribution checklist:

  • The pull request does not introduce [breaking changes]
  • CHANGELOG is updated for new features, bug fixes or other significant changes.
  • I have read the contribution guidelines.

General Guidelines and Best Practices

  • Title of the pull request is clear and informative.
  • There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For more information on cleaning up the commits in your PR, see this page.

Testing Guidelines

  • Pull request includes test coverage for the included changes.

@github-actions github-actions bot added Azure.Identity Monitor Monitor, Monitor Ingestion, Monitor Query Search Storage Storage Service (Queues, Blobs, Files) Tables labels Oct 18, 2024
@azure-sdk
Copy link
Collaborator

API change check

API changes are not detected in this pull request.

@alzimmermsft alzimmermsft merged commit 8c639ed into Azure:main Oct 23, 2024
80 checks passed
@alzimmermsft alzimmermsft deleted the AzAll_UseSharedExecutorServiceInMoreLocations branch October 23, 2024 12:42
billwert pushed a commit that referenced this pull request Jan 10, 2025
@alzimmermsft @billwert
Use SharedExecutorService in more locations (#42468)
72074c5 
Use SharedExecutorService in more locations
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@srnagar srnagar srnagar approved these changes

@jairmyree jairmyree Awaiting requested review from jairmyree jairmyree is a code owner

@vcolin7 vcolin7 Awaiting requested review from vcolin7 vcolin7 is a code owner

@ibrahimrabab ibrahimrabab Awaiting requested review from ibrahimrabab ibrahimrabab is a code owner

@seanmcc-msft seanmcc-msft Awaiting requested review from seanmcc-msft seanmcc-msft is a code owner

@ibrandes ibrandes Awaiting requested review from ibrandes ibrandes is a code owner

@kyleknap kyleknap Awaiting requested review from kyleknap kyleknap is a code owner

@lmolkova lmolkova Awaiting requested review from lmolkova lmolkova is a code owner

@g2vinay g2vinay Awaiting requested review from g2vinay g2vinay is a code owner

@billwert billwert Awaiting requested review from billwert billwert is a code owner

@joshfree joshfree Awaiting requested review from joshfree joshfree is a code owner

@sarangan12 sarangan12 Awaiting requested review from sarangan12 sarangan12 is a code owner automatically assigned from Azure/azure-sdk-write-monitor-data-plane

@pvaneck pvaneck Awaiting requested review from pvaneck pvaneck is a code owner automatically assigned from Azure/azure-sdk-write-monitor-data-plane

@KevinBlasko KevinBlasko Awaiting requested review from KevinBlasko KevinBlasko is a code owner automatically assigned from Azure/azure-sdk-write-monitor-data-plane

@KarishmaGhiya KarishmaGhiya Awaiting requested review from KarishmaGhiya KarishmaGhiya is a code owner automatically assigned from Azure/azure-sdk-write-monitor-data-plane

@scottaddie scottaddie Awaiting requested review from scottaddie scottaddie is a code owner automatically assigned from Azure/azure-sdk-write-monitor-data-plane

@nisha-bhatia nisha-bhatia Awaiting requested review from nisha-bhatia nisha-bhatia is a code owner automatically assigned from Azure/azure-sdk-write-monitor-data-plane

@Haiying-MSFT Haiying-MSFT Awaiting requested review from Haiying-MSFT Haiying-MSFT is a code owner automatically assigned from Azure/azure-sdk-write-monitor-data-plane

@minhanh-phan minhanh-phan Awaiting requested review from minhanh-phan minhanh-phan is a code owner automatically assigned from Azure/azure-sdk-write-identity

Assignees
No one assigned
Labels
Azure.Identity Monitor Monitor, Monitor Ingestion, Monitor Query Search Storage Storage Service (Queues, Blobs, Files) Tables
Projects
Azure Identity SDK Improvements
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@alzimmermsft @azure-sdk @srnagar