-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
mgmt azure-json, migrate azure-resourcemanager-redis #41410
Conversation
...r-redis/src/main/java/com/azure/resourcemanager/redis/implementation/ConfigurationUtils.java
Show resolved
Hide resolved
API change check APIView has identified API level changes in this PR and created following API reviews. |
CI error is caused by |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
OK for me.
Reading the java file and parse it via regex seems too fragile. It depends too much on how the code is written (not even sure if a newline would break the logic).
But I didn't see alternative though.
Agree. Both formatter and codegen logic can affect the generated code. Let's see if this is an issue in the future.. Alternative would be reading directly from swagger file based on the tag. Though it still rely on the folder/file structure. |
Description
manual code(mainly RedisConfigurationTest migration): 5e801f3
regened locally to fix
validate()
: deb2f51autorest PR: Azure/autorest.java#2895
Please add an informative description that covers that changes made by the pull request and link all relevant issues.
If an SDK is being regenerated based on a new swagger spec, a link to the pull request containing these swagger spec changes has been included above.
All SDK Contribution checklist:
General Guidelines and Best Practices
Testing Guidelines