Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mgmt azure-json, migrate azure-resourcemanager-redis #41410

Merged
merged 5 commits into from
Aug 8, 2024

Conversation

XiaofeiCao
Copy link
Contributor

@XiaofeiCao XiaofeiCao commented Aug 2, 2024

Description

manual code(mainly RedisConfigurationTest migration): 5e801f3

regened locally to fix validate(): deb2f51

autorest PR: Azure/autorest.java#2895

Please add an informative description that covers that changes made by the pull request and link all relevant issues.

If an SDK is being regenerated based on a new swagger spec, a link to the pull request containing these swagger spec changes has been included above.

All SDK Contribution checklist:

  • The pull request does not introduce [breaking changes]
  • CHANGELOG is updated for new features, bug fixes or other significant changes.
  • I have read the contribution guidelines.

General Guidelines and Best Practices

  • Title of the pull request is clear and informative.
  • There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For more information on cleaning up the commits in your PR, see this page.

Testing Guidelines

  • Pull request includes test coverage for the included changes.

@github-actions github-actions bot added the Mgmt This issue is related to a management-plane library. label Aug 2, 2024
@azure-sdk
Copy link
Collaborator

API change check

APIView has identified API level changes in this PR and created following API reviews.

com.azure.resourcemanager:azure-resourcemanager-redis

@XiaofeiCao
Copy link
Contributor Author

CI error is caused by validate(): Azure/autorest.java#2890

Copy link
Member

@weidongxu-microsoft weidongxu-microsoft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK for me.

Reading the java file and parse it via regex seems too fragile. It depends too much on how the code is written (not even sure if a newline would break the logic).
But I didn't see alternative though.

@XiaofeiCao
Copy link
Contributor Author

OK for me.

Reading the java file and parse it via regex seems too fragile. It depends too much on how the code is written (not even sure if a newline would break the logic). But I didn't see alternative though.

Agree. Both formatter and codegen logic can affect the generated code. Let's see if this is an issue in the future..

Alternative would be reading directly from swagger file based on the tag. Though it still rely on the folder/file structure.

@XiaofeiCao XiaofeiCao merged commit 81d7345 into Azure:main Aug 8, 2024
25 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Mgmt This issue is related to a management-plane library.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants