Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix spring autoconfigure test #40980

Merged
merged 8 commits into from
Jul 8, 2024
Merged

Conversation

conniey
Copy link
Member

@conniey conniey commented Jul 2, 2024

Description

  • Use mcr.microsoft.com to pull container image from.
  • Disable pulling of ryuk image and perform manual clean-up of container.

All SDK Contribution checklist:

  • The pull request does not introduce [breaking changes]
  • CHANGELOG is updated for new features, bug fixes or other significant changes.
  • I have read the contribution guidelines.

General Guidelines and Best Practices

  • Title of the pull request is clear and informative.
  • There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For more information on cleaning up the commits in your PR, see this page.

Testing Guidelines

  • Pull request includes test coverage for the included changes.

@github-actions github-actions bot added the azure-spring All azure-spring related issues label Jul 2, 2024
@azure-sdk
Copy link
Collaborator

API change check

API changes are not detected in this pull request.

@conniey conniey changed the title Specify Docker registry Fix spring autoconfigure test Jul 2, 2024
@conniey conniey force-pushed the spring-tests/container-fix branch from b1a8a3c to bda722f Compare July 3, 2024 22:04
@conniey conniey force-pushed the spring-tests/container-fix branch from 2c95b33 to 825e5ae Compare July 5, 2024 22:39
@conniey
Copy link
Member Author

conniey commented Jul 5, 2024

/azp run java - spring - tests

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@conniey conniey self-assigned this Jul 5, 2024
@conniey
Copy link
Member Author

conniey commented Jul 5, 2024

@Netyyyy Can you look over this PR?

@Netyyyy
Copy link
Member

Netyyyy commented Jul 8, 2024

/azp run java - spring - tests

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@conniey conniey merged commit 33c79f2 into Azure:main Jul 8, 2024
49 checks passed
@conniey conniey deleted the spring-tests/container-fix branch July 8, 2024 16:37
conniey added a commit that referenced this pull request Jul 8, 2024
conniey added a commit that referenced this pull request Jul 8, 2024
Netyyyy pushed a commit to Netyyyy/azure-sdk-for-java that referenced this pull request Jul 9, 2024
* Specify mcr registry to use.

* Fix spelling

* Manually take care of container lifecycle.

* Fix naming of variable.

* Adding console.writeline.

* move environment variable.

* Remove Disabled annotation

* Add prebuild step to set env variable.

(cherry picked from commit 33c79f2)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
azure-spring All azure-spring related issues
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants