Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migrate azure-communication-common to azure-json. #40952

Merged
merged 4 commits into from
Jul 8, 2024
Merged

Migrate azure-communication-common to azure-json. #40952

merged 4 commits into from
Jul 8, 2024

Conversation

conniey
Copy link
Member

@conniey conniey commented Jul 1, 2024 •
edited
Loading

Description

Add azure-json dependency. Remove opens to jackson. Related to #40614

All SDK Contribution checklist:

  • The pull request does not introduce [breaking changes]
  • CHANGELOG is updated for new features, bug fixes or other significant changes.
  • I have read the contribution guidelines.

General Guidelines and Best Practices

  • Title of the pull request is clear and informative.
  • There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For more information on cleaning up the commits in your PR, see this page.

Testing Guidelines

  • Pull request includes test coverage for the included changes.

@conniey conniey self-assigned this Jul 1, 2024
@azure-sdk
Copy link
Collaborator

API change check

APIView has identified API level changes in this PR and created following API reviews.

com.azure:azure-communication-common

@conniey conniey merged commit 1ea9aa3 into Azure:main Jul 8, 2024
19 checks passed
@conniey conniey deleted the communication/json-migration branch July 8, 2024 21:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@srnagar srnagar srnagar left review comments

@vcolin7 vcolin7 vcolin7 approved these changes

@AikoBB AikoBB Awaiting requested review from AikoBB AikoBB is a code owner

@maximrytych-ms maximrytych-ms Awaiting requested review from maximrytych-ms maximrytych-ms is a code owner

@mjafferi-msft mjafferi-msft Awaiting requested review from mjafferi-msft mjafferi-msft is a code owner

Assignees

@conniey conniey

Labels
Communication - Common
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@conniey @azure-sdk @vcolin7 @srnagar