-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ServiceBus metrics #31283
Merged
Merged
ServiceBus metrics #31283
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lmolkova
force-pushed
the
servicebus-metrics
branch
from
October 6, 2022 00:23
95a8912
to
6a0e3f7
Compare
API change check APIView has identified API level changes in this PR and created following API reviews. |
lmolkova
requested review from
mssfang,
JonathanGiles,
anuchandy,
ki1729,
conniey,
liukun-msft,
ZejiaJiang,
alzimmermsft,
srnagar,
vcolin7 and
billwert
as code owners
October 6, 2022 17:54
anuchandy
reviewed
Oct 10, 2022
...ain/java/com/azure/messaging/servicebus/implementation/instrumentation/ServiceBusTracer.java
Outdated
Show resolved
Hide resolved
lmolkova
force-pushed
the
servicebus-metrics
branch
4 times, most recently
from
October 11, 2022 00:45
5918f1e
to
fa3ea41
Compare
ki1729
approved these changes
Oct 12, 2022
anuchandy
reviewed
Oct 12, 2022
...main/java/com/azure/messaging/servicebus/implementation/instrumentation/ServiceBusMeter.java
Outdated
Show resolved
Hide resolved
lmolkova
force-pushed
the
servicebus-metrics
branch
from
October 13, 2022 00:15
d904314
to
0661f5b
Compare
anuchandy
approved these changes
Oct 13, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements ServiceBus part of #25605
Adds following metrics:
{events}
net.peer.name
messaging.destination
(will change)otel.status_code
ok
orerror
seconds
net.peer.name
messaging.destination
messaging.servicebus.subscription_name
{ms}
net.peer.name
messaging.destination
(will change)messaging.servicebus.subscription_name
messaging.servicebus.disposition_status
complete
,abandon
,defer
,suspend
(dead-letter)otel.status_code
ok
orerror
{seqNo}
net.peer.name
messaging.destination
(will change)messaging.servicebus.subscription_name
messaging.servicebus.disposition_status
complete
,abandon
,defer
,suspend
(dead-letter)otel.status_code
ok
orerror
Context: