Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Eng] Add comment for label Legacy #27134

Merged
merged 2 commits into from
Feb 15, 2025
Merged

Conversation

VeryEarly
Copy link
Collaborator

Description

Mandatory Checklist

  • SHOULD update ChangeLog.md file(s) appropriately
    • For SDK-based development mode, update src/{{SERVICE}}/{{SERVICE}}/ChangeLog.md.
      • A snippet outlining the change(s) made in the PR should be written under the ## Upcoming Release header in the past tense.
    • For autorest-based development mode, include the changelog in the PR description.
    • Should not change ChangeLog.md if no new release is required, such as fixing test case only.
  • SHOULD regenerate markdown help files if there is cmdlet API change. Instruction
  • SHOULD have proper test coverage for changes in pull request.
  • SHOULD NOT adjust version of module manually in pull request

@VeryEarly VeryEarly requested a review from isra-fel as a code owner February 15, 2025 09:03
Copy link

Thanks for your contribution! The pull request validation has started. Please revisit this comment for updated status.

@VeryEarly VeryEarly added Legacy based on legacy branch (main/generation branch) prior to non-generation migration and removed Legacy based on legacy branch (main/generation branch) prior to non-generation migration labels Feb 15, 2025
@VeryEarly VeryEarly merged commit b031c87 into main Feb 15, 2025
12 checks passed
@VeryEarly VeryEarly deleted the yabo/add-label-for-legacy-pr branch February 15, 2025 09:47
VeryEarly added a commit that referenced this pull request Feb 17, 2025
* Add comment for label Legacy

* fix indentation
dolauli pushed a commit that referenced this pull request Feb 17, 2025
* Add comment for label Legacy

* fix indentation
VeryEarly added a commit that referenced this pull request Feb 19, 2025
* Add comment for label Legacy

* fix indentation
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants