-
Notifications
You must be signed in to change notification settings - Fork 3.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
comment out ApiManagementHelper.cs #26989
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
️✔️Az.Accounts
️✔️Az.ApiManagement
|
VeryEarly
changed the title
Change resourcemanager sdk dependency for apimanagement to common resourcemanager sdk
comment out ApiManagementHelper.cs
Jan 9, 2025
vidai-msft
approved these changes
Jan 9, 2025
github-actions bot
pushed a commit
that referenced
this pull request
Jan 9, 2025
* Update ApiManagementHelper.cs * Update resource manager namespace imports * Comment out unused code in ApiManagementHelper.cs * Update ApiManagementTests.cs
VeryEarly
added a commit
that referenced
this pull request
Jan 9, 2025
* Update ApiManagementHelper.cs * Update resource manager namespace imports * Comment out unused code in ApiManagementHelper.cs * Update ApiManagementTests.cs
VeryEarly
added a commit
that referenced
this pull request
Jan 9, 2025
* bump up version for az 13.1.0 * comment out ApiManagementHelper.cs (#26989) * Update ApiManagementHelper.cs * Update resource manager namespace imports * Comment out unused code in ApiManagementHelper.cs * Update ApiManagementTests.cs
VeryEarly
added a commit
that referenced
this pull request
Jan 9, 2025
* Update private-link-resource-example.md (#26972) * Remove SSL errors check. (#26973) * Start-AzAutomationRunbook Object ref error (#26924) * Start-AzAutomationRunbook Object ref error * Update ChangeLog.md --------- Co-authored-by: Divyesh Govaerdhanan <divyesh.govaerdhanan@plateauinc.com> Co-authored-by: Yabo Hu <yabhu@microsoft.com> * Fix json format issue (#26978) * Add Managed Identity Support in Azure Disk Encryption (#26652) * Changes * Add UT's * Unwanted changes * Update markdown file * Modified code and handle comments * Update comments and removed unwanted code * update test case * fix comments * fix changelog * Addressed comments * fix changes * Removed unwanted changes * Throw exception when encryption identity is not part of assigned Identities * Remove unwanted changes * Remove changes not required * remove unwanted changes1 * fix remaining unwanted changes * fix identation issues * markdown check --------- Co-authored-by: Anshul Jain <anshjain@microsoft.com> * Adding VirtualRouterAutoScaleConfiguration for Route Server (#26908) * starting changes for ars autoscale * update, get, and create work * saving test progress * updating help docs * UT is recorded * addressing PR comments * updating the session record --------- Co-authored-by: Yan Xu <yanxu1@microsoft.com> * comment out ApiManagementHelper.cs (#26989) * Update ApiManagementHelper.cs * Update resource manager namespace imports * Comment out unused code in ApiManagementHelper.cs * Update ApiManagementTests.cs --------- Co-authored-by: Vincent Dai <23257217+vidai-msft@users.noreply.github.com> Co-authored-by: Divyesh Govardhanan <divyeshgovardhanan@gmail.com> Co-authored-by: Divyesh Govaerdhanan <divyesh.govaerdhanan@plateauinc.com> Co-authored-by: Anshul Jain <20378667+anshuljain26@users.noreply.github.com> Co-authored-by: Anshul Jain <anshjain@microsoft.com> Co-authored-by: ksteinmeyer2023 <135751563+ksteinmeyer2023@users.noreply.github.com> Co-authored-by: Yan Xu <yanxu1@microsoft.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
tests under apimanagement.servicemanagement not following current testfx and is referencing resourcemanager track1 sdk, comment it out for now.
Mandatory Checklist
Please choose the target release of Azure PowerShell. (⚠️ Target release is a different concept from API readiness. Please click below links for details.)
Check this box to confirm: I have read the Submitting Changes section of
CONTRIBUTING.md
and reviewed the following information:ChangeLog.md
file(s) appropriatelysrc/{{SERVICE}}/{{SERVICE}}/ChangeLog.md
.## Upcoming Release
header in the past tense.ChangeLog.md
if no new release is required, such as fixing test case only.