Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

comment out ApiManagementHelper.cs #26989

Merged
merged 4 commits into from
Jan 9, 2025
Merged

comment out ApiManagementHelper.cs #26989

merged 4 commits into from
Jan 9, 2025

Conversation

VeryEarly
Copy link
Contributor

@VeryEarly VeryEarly commented Jan 9, 2025

Description

tests under apimanagement.servicemanagement not following current testfx and is referencing resourcemanager track1 sdk, comment it out for now.

Mandatory Checklist

  • SHOULD update ChangeLog.md file(s) appropriately
    • For SDK-based development mode, update src/{{SERVICE}}/{{SERVICE}}/ChangeLog.md.
      • A snippet outlining the change(s) made in the PR should be written under the ## Upcoming Release header in the past tense.
    • For autorest-based development mode, include the changelog in the PR description.
    • Should not change ChangeLog.md if no new release is required, such as fixing test case only.
  • SHOULD regenerate markdown help files if there is cmdlet API change. Instruction
  • SHOULD have proper test coverage for changes in pull request.
  • SHOULD NOT adjust version of module manually in pull request

Copy link

azure-client-tools-bot-prd bot commented Jan 9, 2025

️✔️Az.Accounts
️✔️Build
️✔️PowerShell Core - Windows
️✔️Windows PowerShell - Windows
️✔️Az.ApiManagement
️✔️Build
️✔️PowerShell Core - Windows
️✔️Windows PowerShell - Windows
️✔️Test
️✔️PowerShell Core - Linux
️✔️PowerShell Core - MacOS
️✔️PowerShell Core - Windows
️✔️Windows PowerShell - Windows

@VeryEarly VeryEarly changed the title Change resourcemanager sdk dependency for apimanagement to common resourcemanager sdk comment out ApiManagementHelper.cs Jan 9, 2025
@VeryEarly VeryEarly merged commit dd82de4 into main Jan 9, 2025
12 checks passed
@VeryEarly VeryEarly deleted the VeryEarly-patch-1 branch January 9, 2025 09:05
github-actions bot pushed a commit that referenced this pull request Jan 9, 2025
* Update ApiManagementHelper.cs

* Update resource manager namespace imports

* Comment out unused code in ApiManagementHelper.cs

* Update ApiManagementTests.cs
VeryEarly added a commit that referenced this pull request Jan 9, 2025
* Update ApiManagementHelper.cs

* Update resource manager namespace imports

* Comment out unused code in ApiManagementHelper.cs

* Update ApiManagementTests.cs
VeryEarly added a commit that referenced this pull request Jan 9, 2025
* bump up version for az 13.1.0

* comment out ApiManagementHelper.cs (#26989)

* Update ApiManagementHelper.cs

* Update resource manager namespace imports

* Comment out unused code in ApiManagementHelper.cs

* Update ApiManagementTests.cs
VeryEarly added a commit that referenced this pull request Jan 9, 2025
* Update private-link-resource-example.md (#26972)

* Remove SSL errors check. (#26973)

* Start-AzAutomationRunbook Object ref error (#26924)

* Start-AzAutomationRunbook Object ref error

* Update ChangeLog.md

---------

Co-authored-by: Divyesh Govaerdhanan <divyesh.govaerdhanan@plateauinc.com>
Co-authored-by: Yabo Hu <yabhu@microsoft.com>

* Fix json format issue (#26978)

* Add Managed Identity Support in Azure Disk Encryption (#26652)

* Changes

* Add UT's

* Unwanted changes

* Update markdown file

* Modified code and handle comments

* Update comments and removed unwanted code

* update test case

* fix comments

* fix changelog

* Addressed comments

* fix changes

* Removed unwanted changes

* Throw exception when encryption identity is not part of assigned Identities

* Remove unwanted changes

* Remove changes not required

* remove unwanted changes1

* fix remaining unwanted changes

* fix identation issues

* markdown check

---------

Co-authored-by: Anshul Jain <anshjain@microsoft.com>

* Adding VirtualRouterAutoScaleConfiguration for Route Server (#26908)

* starting changes for ars autoscale

* update, get, and create work

* saving test progress

* updating help docs

* UT is recorded

* addressing PR comments

* updating the session record

---------

Co-authored-by: Yan Xu <yanxu1@microsoft.com>

* comment out ApiManagementHelper.cs (#26989)

* Update ApiManagementHelper.cs

* Update resource manager namespace imports

* Comment out unused code in ApiManagementHelper.cs

* Update ApiManagementTests.cs

---------

Co-authored-by: Vincent Dai <23257217+vidai-msft@users.noreply.github.com>
Co-authored-by: Divyesh Govardhanan <divyeshgovardhanan@gmail.com>
Co-authored-by: Divyesh Govaerdhanan <divyesh.govaerdhanan@plateauinc.com>
Co-authored-by: Anshul Jain <20378667+anshuljain26@users.noreply.github.com>
Co-authored-by: Anshul Jain <anshjain@microsoft.com>
Co-authored-by: ksteinmeyer2023 <135751563+ksteinmeyer2023@users.noreply.github.com>
Co-authored-by: Yan Xu <yanxu1@microsoft.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants