Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update to use Gallery 2024-03-03 calls #26864

Merged
merged 6 commits into from
Dec 20, 2024
Merged

Update to use Gallery 2024-03-03 calls #26864

merged 6 commits into from
Dec 20, 2024

Conversation

grizzlytheodore
Copy link
Member

@grizzlytheodore grizzlytheodore commented Dec 12, 2024 •
edited
Loading

Description

Mandatory Checklist

  • SHOULD update ChangeLog.md file(s) appropriately
    • For SDK-based development mode, update src/{{SERVICE}}/{{SERVICE}}/ChangeLog.md.
      • A snippet outlining the change(s) made in the PR should be written under the ## Upcoming Release header in the past tense.
    • For autorest-based development mode, include the changelog in the PR description.
    • Should not change ChangeLog.md if no new release is required, such as fixing test case only.
  • SHOULD regenerate markdown help files if there is cmdlet API change. Instruction
  • SHOULD have proper test coverage for changes in pull request.
  • SHOULD NOT adjust version of module manually in pull request

@azure-client-tools-bot-prd azure-client-tools-bot-prd
Copy link

azure-client-tools-bot-prd bot commented Dec 12, 2024 •
edited
Loading

️✔️Az.Accounts
️✔️Build
️✔️PowerShell Core - Windows
️✔️Windows PowerShell - Windows
️✔️Az.Compute
️✔️Build
️✔️PowerShell Core - Windows
️✔️Windows PowerShell - Windows
️✔️Breaking Change Check
️✔️PowerShell Core - Windows
️✔️Windows PowerShell - Windows
️✔️Signature Check
️✔️PowerShell Core - Windows
️✔️Windows PowerShell - Windows
️✔️Help File Existence Check
️✔️PowerShell Core - Windows
️✔️Windows PowerShell - Windows
️✔️Generated Sdk Check
️✔️PowerShell Core - Windows
️✔️Windows PowerShell - Windows
️✔️Test
️✔️PowerShell Core - Linux
️✔️PowerShell Core - MacOS
️✔️PowerShell Core - Windows
️✔️Windows PowerShell - Windows
️✔️Az.KeyVault
️✔️Build
️✔️PowerShell Core - Windows
️✔️Windows PowerShell - Windows
️✔️Az.ManagedServiceIdentity
️✔️Build
️✔️PowerShell Core - Windows
️✔️Windows PowerShell - Windows
️✔️Az.Monitor
️✔️Build
️✔️PowerShell Core - Windows
️✔️Windows PowerShell - Windows
️✔️Az.Network
️✔️Build
️✔️PowerShell Core - Windows
️✔️Windows PowerShell - Windows
️✔️Test
️✔️PowerShell Core - Linux
️✔️PowerShell Core - MacOS
️✔️PowerShell Core - Windows
️✔️Windows PowerShell - Windows
️✔️Az.OperationalInsights
️✔️Build
️✔️PowerShell Core - Windows
️✔️Windows PowerShell - Windows
️✔️Az.PrivateDns
️✔️Build
️✔️PowerShell Core - Windows
️✔️Windows PowerShell - Windows
️✔️Az.RecoveryServices
️✔️Build
️✔️PowerShell Core - Windows
️✔️Windows PowerShell - Windows
️✔️Test
️✔️PowerShell Core - Linux
️✔️PowerShell Core - MacOS
️✔️PowerShell Core - Windows
️✔️Windows PowerShell - Windows
️✔️Az.Security
️✔️Build
️✔️PowerShell Core - Windows
️✔️Windows PowerShell - Windows
️✔️Test
️✔️PowerShell Core - Linux
️✔️PowerShell Core - MacOS
️✔️PowerShell Core - Windows
️✔️Windows PowerShell - Windows
️✔️Az.Sql
️✔️Build
️✔️PowerShell Core - Windows
️✔️Windows PowerShell - Windows
️✔️Az.Ssh
️✔️Build
️✔️PowerShell Core - Windows
️✔️Windows PowerShell - Windows
️✔️Test
️✔️PowerShell Core - Linux
️✔️PowerShell Core - MacOS
️✔️PowerShell Core - Windows
️✔️Windows PowerShell - Windows
️✔️Az.Storage
️✔️Build
️✔️PowerShell Core - Windows
️✔️Windows PowerShell - Windows

haagha
haagha previously approved these changes Dec 12, 2024
View reviewed changes
@grizzlytheodore
Copy link
Member Author

@VeryEarly there is static analysis failure: "Az.Compute","src/Compute/Compute.Management.Sdk","1","9080","Do not support updating SDK using autorest csharp.","Please update the Readme.md to generate code by autorest powershell v4."

Compute is still dependent on track 1 .net sdk generation. Can I suppress this?

I will be reaching out to PS team in january to discuss compute's track 1 dependency.

@VeryEarly
Copy link
Contributor

please go ahead

@VeryEarly there is static analysis failure: "Az.Compute","src/Compute/Compute.Management.Sdk","1","9080","Do not support updating SDK using autorest csharp.","Please update the Readme.md to generate code by autorest powershell v4."

Compute is still dependent on track 1 .net sdk generation. Can I suppress this?

I will be reaching out to PS team in january to discuss compute's track 1 dependency.

@grizzlytheodore
Copy link
Member Author

please go ahead

@VeryEarly there is static analysis failure: "Az.Compute","src/Compute/Compute.Management.Sdk","1","9080","Do not support updating SDK using autorest csharp.","Please update the Readme.md to generate code by autorest powershell v4."
Compute is still dependent on track 1 .net sdk generation. Can I suppress this?
I will be reaching out to PS team in january to discuss compute's track 1 dependency.

done! @VeryEarly

@VeryEarly VeryEarly merged commit c860c84 into main Dec 20, 2024
12 checks passed
@VeryEarly VeryEarly deleted the feature/cplat-2024-03-03 branch December 20, 2024 08:48
github-actions bot pushed a commit that referenced this pull request Dec 20, 2024
@grizzlytheodore @azure-powershell-bot
Update to use Gallery 2024-03-03 calls (#26864)
04a2417 
* update readme

* update readme

* update with gallery 2024-03-03 version

* changelog

* suppress static analysis
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@VeryEarly VeryEarly VeryEarly approved these changes

@haagha haagha haagha left review comments

@bilaakpan-ms bilaakpan-ms Awaiting requested review from bilaakpan-ms bilaakpan-ms is a code owner

@Sandido Sandido Awaiting requested review from Sandido Sandido is a code owner

Assignees

@VeryEarly VeryEarly

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@grizzlytheodore @VeryEarly @haagha