Update embedded logging #2337
Merged
Update embedded logging #2337
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ehamai
reviewed
Feb 13, 2018
| return Observable.of(null); | ||
| }) | ||
| .retry() |
There was a problem hiding this comment.
If you have the do/retry at the end, you don't need this one. If an error is thrown, the last one will catch it and retry the entire timer event. #Resolved
hartra344
added a commit
that referenced
this pull request
Feb 13, 2018
* Making sure selected option in DropDownComponent matches the selected option in the native select element (fixes #2060) * Add CRM headers (#2225) * Revert "Check referer before checking X-MS-CLIENT-PRINCIPAL-NAME (#2218)" This reverts commit 300746c. * add keyboard controls to download function app * CRM headers only on create and delete (#2226) * rp update * add headers only on create and delete calls * pr updates and add headers for get entities * update delete calls to include headers * Tentatively remove MSA login for Try Functions * update icon (#2236) fixes #2235 * Use ARM url specified from Ibiza for national clouds (#2239) * Revert "Revert "Check referer before checking X-MS-CLIENT-PRINCIPAL-NAME (#2218)"" This reverts commit 481a96b. * Use ARM url specified from Ibiza for national clouds * Fixing CR comments * Experimental Language Toggle (#2238) * Experimental Language Toggle * pr updates * Add TIP1 to accepted origins (#2242) * Handling namespace for embedded scenario (#2237) * Fixes #1592 - [Accessibility] Screen reader does not read tree node options when in focus (#2221) * Minor embedded updates (#2245) * update templates and filter out errors * remove retrieve option * Fixing runtime upgrade warning string * Updating Ibiza redirect URL's (#2247) * Minor fixes to disable some features that don't work in national clouds (#2249) * Fix all functions caching (#2250) * Fix all functions caching on create * update function create calls * nit update * Change SiteManage component to open the new App Service Plan blade * Change Destroy to Delete (#2252) * Fixing build * Add durable resources (#2251) * CICD Rework ( Deployment Center) (#2205) * CICD Rework * Fixing a build break and updating the portal-resources.ts file * Fixing Resources from a bad merge * Adding flag in tsc to not check lib typings * correcting import casing for linux build server * Fixing issues in build with unused variables * Polish adjustments dashboard tables and auto refreshing of data * adding state to bitbucket and github oauth * cleaned up deployment detail log and fixed some translate pipes * removing unused variables to make compiler happy * removing bad debug logging from server code * Made first pass at a basic summary page * adding some support for summary of Local Git Choice * first pass at PR Comments, any that are currently marked resolved should be fixed here * Adjustments based on PR comments * Fixing build break * Update travis.yml angular cli * Removing nodejs server auth and making pug use minified * adding production check for optimized js files * adding AI support on the server * fixing azure head pug * Fixing some bugs around loading * Fixing PR changes * Hiding Deployment Center behind a feature flag * Fixing build breaks from last commit * adjustments based on PR comments * Last of PR comments * Fixing file name casing issues for linux builds * securing session cookie * fixing file names to match our format * Addressing PR Comment * Stop showing invalid connection string types, except when already configured (fixes #2248) * Adding build badges * Fixing windows local server running (#2268) * Fixes #2267 and Fixes #2227 Adding mime type for static json files for iisnode (#2269) * Let NodeJS handle static file loading * Trying different fix * Embedded updates (#2271) * Add preview and update editor name for embedded * Add ibiza support for deployment center (#2272) * Let NodeJS handle static file loading * Trying different fix * Adding support for loading deployment center inside of ibiza * fixing build * build fixes * Updated settings file to format TS files on save * Fixing deployment center to load itself rather than app settings * Adding site service and generalizing conditional-http-client (#2266) * Adding site service and generalizing conditional-http-client * Removing arm-preconditions * Moving precondition.ts back to where it was originally * Removing deployment center auth state check from returning auth tokens * Adding telemetry for AppSettings and creating base FeatureComponent (#2280) * Adding telemetry for AppSettings and creating base FeatureComponent * Updating with code review comments * Added parent component concept to make sure we log feature timings only when a parent exists to represent the entire feature * Whitelist update and accessibility updates (#2273) * whitelist update and accessibility updates * remove comment * pr updates * Making sure the form control and displayed value are in sync for the AutoSwapSlotName dropdown (fixes #2275) * EventGrid UI support in function2.0. Fixes #2199 * Disable "enable/disable" and "delete" for VS functions * Add variable cdn url injected at build time * Setting view cache to true on node server to check performance increase in next * making cdn url in body.pug correct * Fixing typo in index.pug that is preventing the rendering in ng-min * Updating the referenced templates (#2291) * Fixing web config to add static file mime types * Make gulp ignore resources made specifically for Visual Studio that aren't used for portal * Updating template package, fixing resources * Updating the swagger editor to match the luminosity ratio (#2288) * manage blade, focus on input when adding key * [API definition blade] adding role for expand / collapse (#2286) * Create from Integrate Tab (#2296) * Embedded templates "type" update (#2295) * xrmwebhooktrigger replaces synctrigger * update binding type * Moving as many pieces as possible to go through CDN rather than directly to the app (#2300) * Add variable cdn url injected at build time * trigger build * Adding Woff Mime type to web.config * fixing mime map in web.config * Adding mime types to web config * moving more assets to load from cdn * fixing mime types * adding ttf mime type * get resources from cdn when possible * Moving pieces to load from CDN where available * fixing cdn image loading * Adding cache breaking cdn calls * focus on combo box when get function url clicked * Adding Cache break query for image loading (#2303) * add role and label to click to show/click to hide * undo template update (#2305) * Add redirects for people going directly to functions.azure.com (#2313) * correct fowarding address for try functions * Updated Travis CI link * xrmwebhooktrigger change (#2314) * Fixes #2267 - Updating conditional http client to handle complex error types being thrown (#2311) * Fixing TriggerFunctionAPIM api for ASP.Net controller * Fixing build * Implement /api/runtimetoken in node server. Closes #2253 (#2298) * Implement /api/runtimetoken in node server. Closes #2253 * CR 1 * Temporarily updating APIMTrigger API in node for debugging purposes * Updating site-config to do permission/lock checks after initial load (#2318) * Updating site-config to do permission/lock checks after initial load * Add error handling to several components * Fixing connection string type * Error handle updates (#2323) * creation error handle * update log error catch * type update * Support linux function apps that don't have scm endpoint (#2322) * Support linux function apps that don't have scm endpoint * Updating site summary and site manage tabs to inherit from FeatureComponent (#2326) * Updating site summary and site manage tabs to inherit from FeatureComponent * Updated SiteEnabledFeaturesComponent to be a FeatureComponent * Cleaning up based on PR feedback * PR feedback * Upgrading from Angular 4 to Angular 5 (#2335) * Update embedded API version (#2336) * add role link to revoke renew * removing vendor import script that is not there in Angular 5 * Fixing local loading * Update embedded logging (#2337) * update embedded logging * remove first do/retry * Only display error on HostStatus === 'Error'. Closes #2330 * Fixing bug in embedded logging
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.