Accessibility updates for 'delete function' button in FunctionManageComponent #2158
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ehamai
reviewed
Dec 15, 2017
| <span class="clickable delete-app" (click)="deleteFunction()" [fnWriteAccess]="functionApp"> | ||
| <span load-image="image/delete.svg" class="icon-small"></span> | ||
| <button class="delete-app" (click)="deleteFunction()" [fnWriteAccess]="functionApp"> | ||
| <span load-image="image/delete.svg" class="icon-small" role="presentation"></span> |
There was a problem hiding this comment.
role="presentation" [](start = 75, length = 19)
Is this actually necessary? Does the screenreader try to read it or something if it's placed within a focusable element?
There was a problem hiding this comment.
Based on testing with Narrator, setting this attribute doesn't make any difference here since the doesn't contain any text.
(If there were text inside the , Narrator would read it unless the span had role="presentation".)
I will leave it since I'm not entirely sure, and the ARIA documentation states that all children of a element need to be presentational.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.