Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix new link for try function #2122

Merged
merged 2 commits into from
Dec 4, 2017
Merged

Conversation

ammanifold
Copy link
Contributor

fixes #2090

image

@dnfclas
Copy link

dnfclas commented Dec 4, 2017

@agruning,
Thanks for having already signed the Contribution License Agreement. Your agreement was validated by .NET Foundation. We will now review your pull request.
Thanks,
.NET Foundation Pull Request Bot

margin-left: 25px;
margin-bottom: 4px;
align-self: flex-end;
}
Copy link
Contributor

@andimarc andimarc Dec 4, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why not combine these in a single declaration?

.link, .link-position { ... } #Closed

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

.link inherits the color and hover characteristic of a link, but with this component we only want the correct positioning


In reply to: 154775843 [](ancestors = 154775843)

Copy link
Contributor

@andimarc andimarc Dec 4, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes. I wasn't suggesting that you get rid of the ".link-position" class, just that you could combine these two blocks as below:

.link, .link-position {
margin-left: 25px;
margin-bottom: 4px;
align-self: flex-end;
}


In reply to: 154776451 [](ancestors = 154776451,154775843)

Copy link
Contributor

@andimarc andimarc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@ammanifold ammanifold merged commit 2f7ce6c into Azure:dev Dec 4, 2017
@ammanifold ammanifold deleted the algrunin-tryFix branch January 30, 2018 18:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Try Function][Create Function] Message box of 'new connection' button is cut off
3 participants