Some standalone and other fixes #2110

exc3eed · 2017-12-01T23:34:03Z

Login logout experiences for standalone version
Custom popup window for Storage and Sql connection string for standalone version
Unique subscription name validation is added for standalone version
Hide refresh and create new app when subscription list is empty for standalone version
Refresh button is removed from subscription menu for standalone version
innerHtml is used for for displaying error text/content/link properly in cron validation section
sidenav padding is removed for standalone version
App setting and visual studio option is removed from app download dialog box

…function page. Dropdown is now updated after generic appsetings popup window closed

…from subscription menu bar

… use well known key name: 'AzureWebJobsStorage'

…lso display value changed

…te function App page

dnfclas · 2017-12-01T23:34:07Z

@exc3eed,
Thanks for having already signed the Contribution License Agreement. Your agreement was validated by .NET Foundation. We will now review your pull request.
Thanks,
.NET Foundation Pull Request Bot

exc3eed · 2017-12-01T23:49:40Z

...ions.AngularClient/src/app/subscription/create-subscription/create-subscription.component.ts

+    return (control: AbstractControl): {[key: string]: any} => {
+      return Promise.resolve({ friendlySubName: 'Check sub' });
+    };
+  };


This is not needed. Remove it. A separate validation class is already created and used #Resolved

hartra344

hartra344 · 2017-12-04T21:32:04Z

AzureFunctions.AngularClient/src/app/pickers/sql/sql.component.ts

+
+    ngOnInit() {
+    }
+


nit: whitespace in this file #Resolved

hartra344 · 2017-12-04T21:32:17Z

AzureFunctions.AngularClient/src/app/pickers/storage/storage.component.ts

+import { SelectOption } from '../../shared/models/select-option';
+import { TranslateService } from '@ngx-translate/core';
+import { PortalResources } from '../../shared/models/portal-resources';
+


nit: whitespace #Resolved

hartra344 · 2017-12-04T21:32:41Z

AzureFunctions.AngularClient/src/app/shared/validators/subscriptionDisplayNameValidator.ts

+import { TranslateService } from '@ngx-translate/core';
+import { UserService } from './../../shared/services/user.service';
+import { Subscription } from './../../shared/models/subscription';
+


whitespace #Resolved

ammanifold · 2017-12-04T22:03:21Z

AzureFunctions/ResourcesPortal/Resources.resx

@@ -181,7 +181,10 @@
    <value>View files</value>
  </data>
  <data name="functionNew_chooseTemplate" xml:space="preserve">
-    <value>Choose a template below or</value>
+    <value>Choose a template below</value>


I think you should make a new variable for this. Currently the "or" is needed as the message is: "Choose a template below or go to the quickstart" so omitting "or" would not make sense #Resolved

We are using "or". "or" is defined in line 337

In reply to: 154789230 [](ancestors = 154789230)

ammanifold · 2017-12-04T22:19:09Z

AzureFunctions.AngularClient/src/app/pickers/storage/storage.component.html

+                                <radio-selector [options]="options" [defaultValue]="optionTypes.azure" (value)="optionsChange.next($event)"></radio-selector>
+                        </div>        
+                        <div [class.disabled] = "option ===  optionTypes.azure">
+                            <input [disabled] = "option ===  optionTypes.azure" type="text" placeholder="{{'storage_endpoint_empty_text' | translate}}" [(ngModel)]="endpoint" />


<input [disabled] = "option === optionTypes.azure" type="text" placeholder="{{'storage_endpoint_empty_text' | translate}}" [(ngModel)]="endpoint" /> [](start = 28, length = 149)

nit: line to long, format so there is one attribute per line #Resolved

ammanifold · 2017-12-04T22:20:49Z

AzureFunctions.AngularClient/src/app/pickers/storage/storage.component.ts

+    }
+
+
+    @Input() set functionApp(functionApp: FunctionApp) {


nit: whitespace #Resolved

afarok added 30 commits November 8, 2017 21:59

Some standalone fixes

1b7cbee

standalone loggedinuser info is now a seperate component

5b0b461

Some css fixes for standalone portal

7fe2ae4

some minor css and standalone refactoring

7379093

standlone logout implemented

8abbdda

domain name from user given name is removed. some css fixes

0f7df5c

Loading... issue fixed for empty subscription list

08b0991

Some refactoring

9218878

merge from asfarok-standalonechanges

4f90983

Merge from dev

be37d76

Merge branch 'dev' into asfarok-standalonechanges2

981b29b

Merge from dev

f9f1b5c

Merge branch 'dev' into asfarok-standalonechanges2

1e9a9a3

Custom popup window for Storage and generic appsetings in create new …

eb85ac1

…function page. Dropdown is now updated after generic appsetings popup window closed

Merge from dev

00a0722

api/logout is used for logging out a user

22907b7

logout icon is added

3dad6e2

logout icon's color changed to red

d730acb

tree-node menu styling fixes

c32fb58

'go to the quickstart' is removed for standalone portal

516e0b1

Unique subscription name validation is added

5f6ef10

Hide refresh icon when subscription is empty and remove refresh icon …

a506eaf

…from subscription menu bar

sidenav padding is removed for standlone portal

4501770

(Create function: Storage Picker)First storage connection string must…

69a9ce8

… use well known key name: 'AzureWebJobsStorage'

drop-down is used instead of radio button in function app creation. A…

d28b848

…lso display value changed

Custom picker/popup (Storage, Generic) issue for existing function fixed

7e66b2a

Merge from dev

fc38dfe

Sql Storage picker added for function template. Text changes for Crea…

e68337c

…te function App page

innerHtml is used to properly show inner html content

1ea3387

disable app settings option and vsoption in download app content dialog

e9793be

afarok added 3 commits December 1, 2017 14:47

Removing unnecessary files

44ecc2b

Merge branch 'dev' into asfarok-standalonechanges2

f5a9a46

Some css fixes

18c5125

dnfclas added the cla-already-signed label Dec 1, 2017

exc3eed requested review from ahmelsayed, alrod, ammanifold, ehamai and jvano December 1, 2017 23:34

exc3eed commented Dec 1, 2017

View reviewed changes

removing unnecessary code + add showUserMenu flag in componenet

7dd8951

hartra344 approved these changes Dec 4, 2017

View reviewed changes

ammanifold reviewed Dec 4, 2017

View reviewed changes

afarok and others added 3 commits December 4, 2017 22:42

PR feedback incorporated

7edb8c4

Merge branch 'dev' into asfarok-standalonechanges2

f2b0bc9

styling fixes

dd2775a

exc3eed merged commit acf8374 into dev Dec 5, 2017

exc3eed deleted the asfarok-standalonechanges2 branch December 5, 2017 22:45

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Some standalone and other fixes #2110

Some standalone and other fixes #2110

exc3eed commented Dec 1, 2017 •

edited

Loading

dnfclas commented Dec 1, 2017

exc3eed Dec 1, 2017 •

edited

Loading

hartra344 left a comment

hartra344 Dec 4, 2017 •

edited by exc3eed

Loading

hartra344 Dec 4, 2017 •

edited by exc3eed

Loading

hartra344 Dec 4, 2017 •

edited by exc3eed

Loading

ammanifold Dec 4, 2017 •

edited by exc3eed

Loading

exc3eed Dec 5, 2017

ammanifold Dec 4, 2017 •

edited by exc3eed

Loading

ammanifold Dec 4, 2017 •

edited by exc3eed

Loading

Some standalone and other fixes #2110

Some standalone and other fixes #2110

Conversation

exc3eed commented Dec 1, 2017 • edited Loading

dnfclas commented Dec 1, 2017

exc3eed Dec 1, 2017 • edited Loading

Choose a reason for hiding this comment

hartra344 left a comment

Choose a reason for hiding this comment

hartra344 Dec 4, 2017 • edited by exc3eed Loading

Choose a reason for hiding this comment

hartra344 Dec 4, 2017 • edited by exc3eed Loading

Choose a reason for hiding this comment

hartra344 Dec 4, 2017 • edited by exc3eed Loading

Choose a reason for hiding this comment

ammanifold Dec 4, 2017 • edited by exc3eed Loading

Choose a reason for hiding this comment

exc3eed Dec 5, 2017

Choose a reason for hiding this comment

ammanifold Dec 4, 2017 • edited by exc3eed Loading

Choose a reason for hiding this comment

ammanifold Dec 4, 2017 • edited by exc3eed Loading

Choose a reason for hiding this comment

exc3eed commented Dec 1, 2017 •

edited

Loading

exc3eed Dec 1, 2017 •

edited

Loading

hartra344 Dec 4, 2017 •

edited by exc3eed

Loading

hartra344 Dec 4, 2017 •

edited by exc3eed

Loading

hartra344 Dec 4, 2017 •

edited by exc3eed

Loading

ammanifold Dec 4, 2017 •

edited by exc3eed

Loading

ammanifold Dec 4, 2017 •

edited by exc3eed

Loading

ammanifold Dec 4, 2017 •

edited by exc3eed

Loading