Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add test logics for app insight #735

Merged
merged 2 commits into from
Oct 12, 2023
Merged

Add test logics for app insight #735

merged 2 commits into from
Oct 12, 2023

Conversation

kaibocai
Copy link
Member

@kaibocai kaibocai commented Oct 10, 2023

Issue describing the changes in this PR

Add test logic for app insight

This PR adds basic verification for the application insight agent. It verifies the agent version is present in the AI portal trace table.
Every time you want to trigger a test running against a specific agent version just update the agent version in azure-pipelines.yml (to avoid mismatch between java worker build pipeline and nightly build pipeline you should also update agent version in azure-pipelines-e2e-integration-tests.yml) and draft a PR, and the test will automatically run inside the build pipeline of java worker.

The application insight is created under subscription simple batch which contains all end2end resources for this repo.

Added 4 new envs to the pipeline:

  1. ApplicationInsightAPIKey: used when query the appinsight portal.
  2. ApplicationInsightAPPID: used when query the appinsight portal.
  3. APPLICATIONINSIGHTS_CONNECTION_STRING: appinsight connection string
  4. APPLICATIONINSIGHTS_ENABLE_AGENT: enable appinsight agent.

Pull request checklist

  • My changes do not require documentation changes
    • Otherwise: Documentation issue linked to PR
  • My changes should not be added to the release notes for the next release
    • Otherwise: I've added my notes to release_notes.md
  • My changes do not need to be backported to a previous version
    • Otherwise: Backport tracked by issue/PR #issue_or_pr
  • I have added all required tests (Unit tests, E2E tests)

Additional information

Additional PR information

Copy link
Member

@shreyas-gopalakrishna shreyas-gopalakrishna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Nice work!

@@ -7,6 +7,8 @@ trigger: none

jobs:
- job: "End_to_end_integration_tests"
variables:
ApplicationInsightAgentVersion: 3.4.15

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can set ApplicationInsightAgentVersion to 3.4.16 at both pipelines as that is latest version used in the worker

correct app id name

add waiting for traces

test api key

add envs used by agent

test

update envs referecing

clean up

test version

update nightly e2e tests pipeline
@kaibocai kaibocai force-pushed the kaibocai/appinsight-test branch from ef53aae to 8ff33e3 Compare October 12, 2023 22:22
@kaibocai kaibocai merged commit 0efd944 into dev Oct 12, 2023
@kaibocai kaibocai deleted the kaibocai/appinsight-test branch October 12, 2023 22:22
shreyas-gopalakrishna pushed a commit that referenced this pull request Jul 14, 2024
* add test logics for app insight

correct app id name

add waiting for traces

test api key

add envs used by agent

test

update envs referecing

clean up

test version

update nightly e2e tests pipeline

* update agent version - fix wrong copy path
shreyas-gopalakrishna pushed a commit that referenced this pull request Jul 14, 2024
* add test logics for app insight

correct app id name

add waiting for traces

test api key

add envs used by agent

test

update envs referecing

clean up

test version

update nightly e2e tests pipeline

* update agent version - fix wrong copy path
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants