-
Notifications
You must be signed in to change notification settings - Fork 268
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add type hints to handshake, inverse, mathematicalconstants #858
Conversation
Don't rename the
and then use |
Also: there's no need to ping us all. The core developers get notifications. |
Sorry about the pinging. Won't happen again. |
You can ping us if you need to just know that we already get notifications for every PR and every comment/update. We're also in very different time zones. |
@janga1997 it looks like this is forked from your short mem player (/~https://github.com/Axelrod-Python/Axelrod/pull/858/files#diff-a964005e2620fada6accc62bb679e816)? So merging this would include that player too but we're still discussing that on #857. |
#808
Only one error in mypy, regarding the file
mathematicalconstants.py
We are importing
e
from themath
module and defining aclass e
too, which is raising some errors.What would you like the
class e(CotoDeRatio):
to be renamed to?@marcharper @drvinceknight @Nikoleta-v3