Add type hints to calculator #850
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Great! Could you add the file to |
janga1997
force-pushed
the
typeHint-calculator
branch
from
ad83f53 to
cf6de74
Compare
marcharper
approved these changes
Feb 5, 2017
|
There's a merge conflict in |
|
@drvinceknight Apparently its a lot easier to resolve it on Github itself, if its just a few lines. |
|
Merge conflicts have reappeared (since I just merge in that other strategy). |
|
Next time, I think I will do a couple of strategies in one single pull request. |
|
@drvinceknight If you have the time, could you respond to me on #379 ? |
|
@drvinceknight I suppose this PR is good for a merge? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#808
No errors with mypy. @drvinceknight @marcharper