Add Type Hints in Deterministic Cache #828
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@drvinceknight @marcharper Is there a type for the variable It is mentioned as Tuple, but I am not sure about the definition. |
|
Take a look at the |
Nikoleta-v3
reviewed
Jan 25, 2017
| @@ -78,7 +79,7 @@ def __setitem__(self, key, value): | |||
| super().__setitem__(self._key_transform(key), value) | |||
|
|
|||
| @staticmethod | |||
| def _is_valid_key(key): | |||
| def _is_valid_key(key) -> boolean: | |||
| @@ -145,7 +146,7 @@ def save(self, file_name: str): | |||
| pickle.dump(self.data, io) | |||
| return True | |||
|
|
|||
| def load(self, file_name: str): | |||
| def load(self, file_name: str) -> boolean: | |||
meatballs
requested changes
Jan 30, 2017
| @@ -145,7 +146,7 @@ def save(self, file_name): | |||
| pickle.dump(self.data, io) | |||
| return True | |||
|
|
|||
| def load(self, file_name): | |||
| def load(self, file_name: str) -> boolean: | |||
There was a problem hiding this comment.
This needs to bool rather than boolean
meatballs
approved these changes
Jan 30, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes a Part of #808