-
Notifications
You must be signed in to change notification settings - Fork 268
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[#647] Add git hook script #648
Conversation
from subprocess import check_output | ||
|
||
# By default, the hook will check to see if the branch name starts with | ||
# 'issue-' and will then prepend whatever follows in the commit message. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just noting that this would be different to current practice? (Where the branch name is just the issue number) Not that this has ever been a strict requirement.
Not a problem, arguably having issue-
is nicer/better.
If this goes in, I'm not sure if having a new directory is potentially less or more confusing (to the very beginner contributor) than a file at the root level (where we already have (Not terribly offended by the new directory either, just a thought.) |
Yep, good idea |
Whilst not overly excited about this, I do think your commit message on this PR look quite nice. I'll probably end up using the damn thing! :) 👍 |
Just something I've already had to write for a work project. Seemed a shame to waste it once the contract finished! |
For consideration!!
fixes #647