Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#647] Add git hook script #648

Merged
merged 6 commits into from
Jun 28, 2016
Merged

[#647] Add git hook script #648

merged 6 commits into from
Jun 28, 2016

Conversation

meatballs
Copy link
Member

For consideration!!

fixes #647

from subprocess import check_output

# By default, the hook will check to see if the branch name starts with
# 'issue-' and will then prepend whatever follows in the commit message.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just noting that this would be different to current practice? (Where the branch name is just the issue number) Not that this has ever been a strict requirement.

Not a problem, arguably having issue- is nicer/better.

@drvinceknight
Copy link
Member

If this goes in, I'm not sure if having a new directory is potentially less or more confusing (to the very beginner contributor) than a file at the root level (where we already have .mailmap, .editorconfig etc...). So perhaps this could be .prepare-commit-msg.py?

(Not terribly offended by the new directory either, just a thought.)

@meatballs
Copy link
Member Author

So perhaps this could be .prepare-commit-msg.py?

Yep, good idea

@drvinceknight
Copy link
Member

Whilst not overly excited about this, I do think your commit message on this PR look quite nice. I'll probably end up using the damn thing! :) 👍

@meatballs
Copy link
Member Author

Whilst not overly excited about this, I do think your commit message on this PR look quite nice. I'll probably end up using the damn thing!

Just something I've already had to write for a work project. Seemed a shame to waste it once the contract finished!

@marcharper marcharper merged commit bc33384 into master Jun 28, 2016
@marcharper marcharper deleted the issue-647 branch August 20, 2016 22:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Consider using a git hook to prepend the issue number to a commit message
3 participants