-
Notifications
You must be signed in to change notification settings - Fork 268
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move to pyproject.toml. #1440
Move to pyproject.toml. #1440
Conversation
This uses hatch. Note I've removed the human player. I don't believe we ever use it. If we want to we can add it back in.
Looks good. I don't personally use the Human strategy but maybe others do. Is there an issue with prompt-toolkit or some other reason it was removed? |
It has always required a bit more maintenance work in terms of compatibility (we've always had to pin it to some older version which sometimes causes problems -- I've often had to fix things on my students' machine to essentially break the human player quietly when they install Axelrod). I'd prefer to remove it, we can always add it back in (or having a separate human lib?) if someone really wants it (and we could take a look at using a more up to date version of |
Ok, let's maybe open an issue saying the human strategy is removed so people can let us know if they use it. If so we can reconsider, and a separate library makes sense to compartmentalize the downsides. Probably we should bump up the version number as well since it's technically removing functionality and people can pin an older version for now if they need it. |
So bump to `4.
Good call, 1e22e0f bumps to |
@Nikoleta-v3 if you get a chance can you take a look at this? |
- Changed TestOpponent class to no longer use __init__ constructor - This fixes the PytestCollectionWarning in axelrod/tests/strategies/test_player.py:353 - This modification allows the test to run without issues. See also: Axelrod-Python#1440
This uses hatch.
Note I've removed the human player. I don't believe we ever use it. If we want to we can add it back in.