Spruce up game and its tests

[langner]

Continued work for #347

[marcharper]

Here's the failing test. Otherwise LGTM:

======================================================================
FAIL: test_payoff_with_passed_axes (axelrod.tests.unit.test_plot.TestPlot)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/home/travis/build/Axelrod-Python/Axelrod/axelrod/tests/unit/test_plot.py", line 208, in test_payoff_with_passed_axes
    msg="Color bar is not in correct location.",
AssertionError: 0.9179031197390574 != 0.8685161708228115 : Color bar is not in correct location.

[drvinceknight]

Why is this better? (I'm perfectly happy, just asking as a learning opportunity :))

[langner]

Well, relative imports are less common (also in the Axelrod library AFAIR) and generally discouraged. The rationale is mostly that relative imports can be ambiguous, whereas absolute ones are not. For more context: https://www.python.org/dev/peps/pep-0328

[drvinceknight]

Awesome: thanks for the explanation.

[langner]

Here's the failing test. Otherwise LGTM:

======================================================================
FAIL: test_payoff_with_passed_axes (axelrod.tests.unit.test_plot.TestPlot)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/home/travis/build/Axelrod-Python/Axelrod/axelrod/tests/unit/test_plot.py", line 208, in test_payoff_with_passed_axes
    msg="Color bar is not in correct location.",
AssertionError: 0.9179031197390574 != 0.8685161708228115 : Color bar is not in correct location.

Is this related at all?

[marcharper]

It doesn't appear to be related, see #1207.

@drvinceknight looks like maybe a dependency change broke a test?

[langner]

It doesn't appear to be related, see #1207.

@drvinceknight looks like maybe a dependency change broke a test?

I'd bet on matplotlib.

In /~https://github.com/matplotlib/matplotlib/releases/tag/v3.0.0 I read:
Improvements to automatic layout of titles, ticks, and GridSpec

Checking in #1208...

[langner]

... and seems that #1208 does fix it, so something changed with matplotlib 3.0.0 that broke TestPlot.

[drvinceknight]

I'd bet on matplotlib.

Good call! Have rerun the tests and they all look fine. I've opened #1209