-
Notifications
You must be signed in to change notification settings - Fork 268
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add a matplotlibrc #1194
Add a matplotlibrc #1194
Conversation
I have also added some comments to ensure we do not reorder these imports.
How does mpl know to look for the rc file there? |
It automatically picks it up from the dir the tests are run from (https://matplotlib.org/users/customizing.html#the-matplotlibrc-file), so this does not change overall behavior of the library but just ensures the correct setting for CI. From link:
|
Great, thanks for the explanation. |
axelrod/tests/unit/test_plot.py
Outdated
|
||
import matplotlib |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
should this one occur before import axelrod
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Import orders don't actually matter anymore, the matplotlibrc
ooverrides everything but I got myself confused there and will reorder to fit PEP8! (and a bonus rerun of CI to make sure it's still working 🤞)
If it works then it's fine with me. Might want to put in a comment somewhere that explains what's happening so someone doesn't move things around later, if that still matters with the rc file. |
The import orders no longer matter (the rc file sets it all) but I'll add a comment to the top of the rc file so we know not to delete it :) |
EDIT:
I have also added some comments to ensure we do not reorder theseimports.