Pin prompt toolkit because of backwards comp. #1184
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marcharper
approved these changes
Jul 6, 2018
|
FYI: 5f048a9 losens the pin but it's falling over on Appveyor I'll figure it out... |
Doing this just to kick start appveyor (for some reason I don't see how to do this on the merge, there's a button on the first check, the pr, but not the second).
|
@meatballs this is probably good to go now, the diff is probably more complicated than it needs to be as I've taken the opportunity to alphabetically sort |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is related to #1183 . Currently a clean install of Axelrod will fail because of backwards incompatible change to
prompt_toolkitversion 2+. This pinsprompt_toolkit.(I suggest we merge this but leave #1182 open as a place holder, there's no rush with unpinning
prompt_toolkitas ipython pins this too I believe: /~https://github.com/ipython/ipython/blob/master/setup.py#L193.)