Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds a memory two generalization of a zero determinant strategy #1099

Merged
merged 6 commits into from
Jul 29, 2017

Conversation

marcharper
Copy link
Member

Note: rebased on #1097, I will rebase onto master after that's merged

@drvinceknight
Copy link
Member

Looks good, any merit to this being in the zero_determinant.py file?

@marcharper
Copy link
Member Author

I thought about it... but it's really more of a 2x2x0 Gambler that happens to be ZD, i.e. there's no analog of the LRStrategy to base it on, and I'd end up importing stuff from test_lookerup.py and friends.

@drvinceknight
Copy link
Member

Cool.

@drvinceknight
Copy link
Member

Looks good to me 👍 (assuming coverage/tests etc...)

@meatballs meatballs merged commit 6e4daa5 into master Jul 29, 2017
@meatballs meatballs deleted the mem2_zd branch July 29, 2017 19:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants