class is Action in action.py, removed alias Action=Actions #1054
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eric-s-s
commented
Jul 6, 2017
| @@ -536,7 +536,7 @@ elsewhere as HardProber. The strategy starts by playing D, D, C, C on the first | |||
| four rounds and then defects forever if the opponent cooperates on rounds | |||
| two and three. Otherwise Prober plays as TitForTat would. | |||
|
|
|||
| *Prober2 came 5th in average score and 6th in wins in S&P's tournament.* | |||
There was a problem hiding this comment.
NOTE: This is a possible minor typo completely unrelated to this PR. It didn't seem worth raising a separate issue. (2 of 2)
eric-s-s
commented
Jul 6, 2017
| @@ -392,7 +392,7 @@ earned in the previous round. WSLS is also known as "Win-Stay-Lose-Switch" and | |||
| - :math:`P(C\,|\,DC) = 0` | |||
| - :math:`P(C\,|\,DD) = 1` | |||
|
|
|||
| *TF2T came 7th in average score and 13th in wins in S&P's tournament.* | |||
There was a problem hiding this comment.
NOTE: This is a possible minor typo completely unrelated to this PR. It didn't seem worth raising a separate issue. (1 of 2)
marcharper
approved these changes
Jul 6, 2017
| @@ -30,9 +30,9 @@ def meta_strategy(self, value: int) -> None: | |||
| By default, treat values like python truth values. Override in child | |||
| classes for alternate behaviors.""" | |||
| if value == 0: | |||
| return Actions.D | |||
| return Action.D | |||
There was a problem hiding this comment.
Let's go with C and D since we've set them above
There was a problem hiding this comment.
Jeeeeez that's a good catch @marcharper 👍
| @@ -536,7 +536,7 @@ elsewhere as HardProber. The strategy starts by playing D, D, C, C on the first | |||
| four rounds and then defects forever if the opponent cooperates on rounds | |||
| two and three. Otherwise Prober plays as TitForTat would. | |||
|
|
|||
| *Prober2 came 5th in average score and 6th in wins in S&P's tournament.* | |||
| @@ -392,7 +392,7 @@ earned in the previous round. WSLS is also known as "Win-Stay-Lose-Switch" and | |||
| - :math:`P(C\,|\,DC) = 0` | |||
| - :math:`P(C\,|\,DD) = 1` | |||
|
|
|||
| *TF2T came 7th in average score and 13th in wins in S&P's tournament.* | |||
drvinceknight
approved these changes
Jul 6, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#816
please note: I believe I found two minor typos in docs/reference/overview_of_strategies.rst. They have nothing to do with this PR, but I thought they might be worth noting (and are a simple check). I'll mark them.