Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes/skia dash array #18001

Merged
merged 1 commit into from
Jan 20, 2025
Merged

Conversation

Gillibald
Copy link
Contributor

@Gillibald Gillibald commented Jan 20, 2025

What does the pull request do?

This PR adds some unit test to ensure dash arrays are properly calculated

What is the current behavior?

What is the updated/expected behavior with this PR?

How was the solution implemented (if it's not obvious)?

Checklist

Breaking changes

Obsoletions / Deprecations

Fixed issues

@avaloniaui-bot
Copy link

You can test this PR using the following package version. 11.3.999-cibuild0054331-alpha. (feed url: https://nuget-feed-all.avaloniaui.net/v3/index.json) [PRBUILDID]

@MrJul MrJul added bug backport-candidate-11.2.x Consider this PR for backporting to 11.2 branch labels Jan 20, 2025
Copy link
Member

@MrJul MrJul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@MrJul MrJul added this pull request to the merge queue Jan 20, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Jan 20, 2025
@jmacato jmacato added this pull request to the merge queue Jan 20, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Jan 20, 2025
@Gillibald Gillibald force-pushed the fixes/skiaDashArray branch from ce9b601 to 1f75eb5 Compare January 20, 2025 12:11
@Gillibald Gillibald enabled auto-merge January 20, 2025 12:12
@avaloniaui-bot
Copy link

You can test this PR using the following package version. 11.3.999-cibuild0054337-alpha. (feed url: https://nuget-feed-all.avaloniaui.net/v3/index.json) [PRBUILDID]

@Gillibald Gillibald added this pull request to the merge queue Jan 20, 2025
Merged via the queue into AvaloniaUI:master with commit 19394e0 Jan 20, 2025
10 checks passed
@Gillibald Gillibald deleted the fixes/skiaDashArray branch January 20, 2025 13:29
@maxkatz6 maxkatz6 added backported-11.2.x and removed backport-candidate-11.2.x Consider this PR for backporting to 11.2 branch labels Feb 15, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants