Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove get_time_automation_fees RPC function #448

Merged
merged 1 commit into from
Oct 9, 2023
Merged

Remove get_time_automation_fees RPC function #448

merged 1 commit into from
Oct 9, 2023

Conversation

imstar15
Copy link
Member

@imstar15 imstar15 commented Oct 8, 2023

Because the query_fee_details function returns both schedule_fee and execution_fee, while get_time_automation_fees only returns schedule_fee.

we should keep only query_fee_details and remove get_time_automation_fees.

@imstar15 imstar15 requested review from v9n and chrisli30 October 8, 2023 04:38
chrisli30
chrisli30 approved these changes Oct 8, 2023
View reviewed changes
Copy link
Member

@chrisli30 chrisli30 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, we discussed this and the get_time_automation_fees was an early experiment which is deprecated now.

@imstar15 imstar15 merged commit 2a0e745 into master Oct 9, 2023
@imstar15 imstar15 deleted the remove_get_time_automation_fees branch October 9, 2023 01:48
v9n pushed a commit that referenced this pull request Oct 11, 2023
@imstar15 @v9n
Remove get_time_automation_fees RPC function (#448)
0c65f7b
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chrisli30 chrisli30 chrisli30 approved these changes

@v9n v9n Awaiting requested review from v9n

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@imstar15 @chrisli30