add fee handling for automation price #436
Conversation
v9n
force-pushed
the
fee-handle-for-automation-price
branch
from
c9050e0 to
550ce0f
Compare
v9n
changed the title
v9n
force-pushed
the
fee-handle-for-automation-price
branch
2 times, most recently
from
b846c99 to
1395048
Compare
There was a problem hiding this comment.
I re-compiled with this PR but found tasks are not being scheduled after Shibuya’s polkadotXcm.send.
@v9n could you test the code with our demo to see what’s wrong? /~https://github.com/OAK-Foundation/automation-price-demo
| @@ -407,13 +444,14 @@ fn test_shift_tasks_movement_through_price_changes() { | |||
| Box::new(NATIVE_LOCATION.into()), | |||
| Box::new(AssetPayment { | |||
| asset_location: MultiLocation::new(0, Here).into(), | |||
| amount: 10000000000000 | |||
| amount: 10 | |||
There was a problem hiding this comment.
Is 10 too small for testing purpose? 10 * 10^10 units would make more sense?
There was a problem hiding this comment.
@v9n, follow up on this comment.
v9n
force-pushed
the
fee-handle-for-automation-price
branch
2 times, most recently
from
164e12a to
f81a7a8
Compare
|
This PR is ready to review again. The issue with failure to schedule job is because we send an invalid XCM v3 location and |
pallets/automation-price/src/lib.rs
Outdated
| #[cfg(not(feature = "dev-queue"))] | ||
| ensure_root(origin)?; | ||
| // #[cfg(not(feature = "dev-queue"))] | ||
| // ensure_root(origin)?; |
There was a problem hiding this comment.
Do we need to turn on this #[cfg(not(feature = "dev-queue"))]?
| @@ -756,12 +765,9 @@ pub mod pallet { | |||
| }; | |||
|
|
|||
| Self::validate_and_schedule_task(task)?; | |||
| // TODO withdraw fee | |||
| //T::FeeHandler::withdraw_fee(&who, fee).map_err(|_| Error::<T>::InsufficientBalance)?; | |||
There was a problem hiding this comment.
Without this line, is the fee actually withdrawn?
v9n
force-pushed
the
fee-handle-for-automation-price
branch
from
cdc9cc0 to
369b795
Compare
Now that we have weight, attempt to handle fee properly.
We charged fee only once when schedule the job succesfully. Because this isn't recurring tasks, we only need to charge once.