accept list of pallet for benchmark action #401
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
when benchmark is being removed between different branch/tag the benchmark may failed to run without updating the hard code list of pallet in github action. We now accept list of pallet to benchmark from the action input.
|
It makes sense to me. Feel free to merge when Charles approves it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
when benchmark is being removed between different branch/tag the benchmark may failed to run without updating the hard code list of pallet in github action.
We now accept list of pallet to benchmark from the action input.
Example of failure due to removing benchmark in xcmp
/~https://github.com/OAK-Foundation/OAK-blockchain/actions/runs/5755356040/job/15602990553